feat: Add ESLint and Oxlint plugin#5
Merged
Merged
Conversation
c16f177 to
4a1964f
Compare
4e0369d to
7351065
Compare
7351065 to
fb60a7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Workflows fail in ways TypeScript will not catch. A step promise can be created but never awaited. A replay input can be mutated. A Promise.race can make replay behavior depend on timing. A random step name can break persisted step reuse. This PR adds lint rules for those workflow-specific footguns.
What
Adds a new package, @sideffect/lint, with ESLint and Oxlint support.
It ships five rules based on Cloudflare's Guidelines
It also adds presets, tests, docs, package exports, and publish workflow support for the new package.
How
The plugin parses workflow syntax and only applies the rules inside recognized workflow bodies.
It recognizes:
The repo then wires the new Oxlint plugin into the root Vite+ lint config so the same rules dogfood against this codebase.