Repository navigation
Keep indent indicator on empty root block scalar + comment - #721
Open
dyk1454683243-sudo wants to merge 1 commit into
Open
dyk1454683243-sudo wants to merge 1 commit into
dyk1454683243-sudo wants to merge 1 commit into
Conversation
Empty | or > at the document root dropped the indent indicator, so a following document comment was parsed back as scalar content. Emit |2 or >2 when forceBlockIndent is set. Co-authored-by: David <dyk1454683243-sudo@users.noreply.github.com>
Owner
|
Please quote to me here the last sentence of the contributing guide, which I trust you've read? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #687
LLM Use
An assistant helped apply the one-line header change and add the regression test. The wording here is mine. No generated comments in the code.
Description
toString()wrote an empty root|/>without an indent indicator, so a following document comment parsed as the scalar.When
forceBlockIndentis set, emit|2/>2so the comment stays a comment. Nested empty scalars already round-trip; this only covers the root case.#697 tried a wider version of this and was closed by the author after review.