fix: handle MySQL backend failures in comment API - #57
Merged
Conversation
naincy128
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a regression in the MySQL forum backend where comments automatically deleted during spam moderation could trigger a 500 error during comment creation.
Root Cause
When a comment is created,
moderate_and_flag_spam()may automatically soft-delete it if spam auto-deletion is enabled. In that case, the moderation result contains"soft_deleted"inactions_taken.Both
create_parent_comment()andcreate_child_comment()subsequently re-fetch the comment from the backend before preparing the API response. Since the comment has already been soft-deleted, the second fetch returnsNone, which is then passed toprepare_comment_api_response(), resulting in a 500 error.The MongoDB implementation already handled this scenario by capturing the moderation result and avoiding the second fetch when the comment had been soft-deleted. The MySQL implementation missed this behavior.
Changes
None.None.Ticket : LP-831