Skip to content

chore: remove transcript editor rollout toggle [LP-1108] - #452

Merged
abhalsod-sonata merged 1 commit into
release-ulmofrom
chore/LP-1108-remove-transcript-editor-toggle
Sep 3, 2026
Merged

chore: remove transcript editor rollout toggle [LP-1108]#452
abhalsod-sonata merged 1 commit into
release-ulmofrom
chore/LP-1108-remove-transcript-editor-toggle

Conversation

@abhalsod-sonata

Copy link
Copy Markdown
Member

Description

Removes the temporary rollout toggle for the in-platform transcript editor, per the product
decision to ship the feature without a flag, and brings the fork in line with the upstream
contribution (openedx#39038) so the two diff as a no-op.

  • cms/djangoapps/contentstore/toggles.py: drop ENABLE_TRANSCRIPT_EDITOR
    (contentstore.enable_transcript_editor) and the transcript_editor_enabled() helper.
  • rest_api/v1/serializers/course_waffle_flags.py: drop the enable_transcript_editor field.
  • rest_api/v1/views/tests/test_course_waffle_flags.py: drop the three flag tests.
  • views/tests/test_transcript_settings.py: add test_transcript_upload_handler_returns_200_on_replace.
    This was missing on the fork — feat: Add transcript editor toggle and update related serializers and tests #267's tests only covered the toggle, so the 200-vs-201 upload
    response change had no coverage. Added at the same location as upstream.

transcript_storage_handlers.py (the 200-on-replace change from #267) is unchanged.

Parity check: the fork's net transcript-editor change after this PR (pre-#267 → this branch)
is line-for-line identical to the upstream PR's change set (28 lines each, zero diff).

Supporting information

Testing instructions

pytest cms/djangoapps/contentstore/views/tests/test_transcript_settings.py \
       cms/djangoapps/contentstore/rest_api/v1/views/tests/test_course_waffle_flags.py

Manual: GET /api/contentstore/v1/course_waffle_flags/<course_key> no longer returns
enable_transcript_editor; uploading a transcript for a language that already has one returns 200,
a new language returns 201.

Copilot AI lite review requested due to automatic review settings September 3, 2026 07:49

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The flag and API surface removal is complete (no remaining references found) and the PR adds targeted test coverage for the 200-vs-201 transcript upload behavior.

Pull request overview

This PR removes the temporary waffle-flag rollout toggle for the Studio in-platform transcript editor, aligning the fork with the upstream implementation by eliminating the flag surface area and associated API/test coverage while adding missing coverage for transcript upload “replace vs create” status codes.

Changes:

  • Removed the contentstore.enable_transcript_editor toggle (ENABLE_TRANSCRIPT_EDITOR) and its transcript_editor_enabled() helper.
  • Removed the enable_transcript_editor field from the course waffle flags API serializer and removed related view tests.
  • Added a regression test ensuring transcript upload returns 200 when replacing an existing transcript (vs 201 when creating a new one).
File summaries
File Description
cms/djangoapps/contentstore/toggles.py Removes the transcript editor CourseWaffleFlag and helper method.
cms/djangoapps/contentstore/rest_api/v1/serializers/course_waffle_flags.py Drops the enable_transcript_editor serializer field/method.
cms/djangoapps/contentstore/rest_api/v1/views/tests/test_course_waffle_flags.py Removes tests/expected defaults for the dropped flag.
cms/djangoapps/contentstore/views/tests/test_transcript_settings.py Adds coverage for 200-on-replace transcript upload behavior.
Review details
  • Files reviewed: 4/4 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@abhalsod-sonata
abhalsod-sonata merged commit 20fc479 into release-ulmo Sep 3, 2026
65 checks passed
@abhalsod-sonata
abhalsod-sonata deleted the chore/LP-1108-remove-transcript-editor-toggle branch September 3, 2026 08:36
abhalsod-sonata added a commit that referenced this pull request Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants