chore: remove transcript editor rollout toggle [LP-1108] - #452
Merged
abhalsod-sonata merged 1 commit intoSep 3, 2026
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The flag and API surface removal is complete (no remaining references found) and the PR adds targeted test coverage for the 200-vs-201 transcript upload behavior.
Pull request overview
This PR removes the temporary waffle-flag rollout toggle for the Studio in-platform transcript editor, aligning the fork with the upstream implementation by eliminating the flag surface area and associated API/test coverage while adding missing coverage for transcript upload “replace vs create” status codes.
Changes:
- Removed the
contentstore.enable_transcript_editortoggle (ENABLE_TRANSCRIPT_EDITOR) and itstranscript_editor_enabled()helper. - Removed the
enable_transcript_editorfield from the course waffle flags API serializer and removed related view tests. - Added a regression test ensuring transcript upload returns 200 when replacing an existing transcript (vs 201 when creating a new one).
File summaries
| File | Description |
|---|---|
cms/djangoapps/contentstore/toggles.py |
Removes the transcript editor CourseWaffleFlag and helper method. |
cms/djangoapps/contentstore/rest_api/v1/serializers/course_waffle_flags.py |
Drops the enable_transcript_editor serializer field/method. |
cms/djangoapps/contentstore/rest_api/v1/views/tests/test_course_waffle_flags.py |
Removes tests/expected defaults for the dropped flag. |
cms/djangoapps/contentstore/views/tests/test_transcript_settings.py |
Adds coverage for 200-on-replace transcript upload behavior. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
alenkadev
approved these changes
Sep 3, 2026
abhalsod-sonata
deleted the
chore/LP-1108-remove-transcript-editor-toggle
branch
September 3, 2026 08:36
abhalsod-sonata
added a commit
that referenced
this pull request
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the temporary rollout toggle for the in-platform transcript editor, per the product
decision to ship the feature without a flag, and brings the fork in line with the upstream
contribution (openedx#39038) so the two diff as a no-op.
cms/djangoapps/contentstore/toggles.py: dropENABLE_TRANSCRIPT_EDITOR(
contentstore.enable_transcript_editor) and thetranscript_editor_enabled()helper.rest_api/v1/serializers/course_waffle_flags.py: drop theenable_transcript_editorfield.rest_api/v1/views/tests/test_course_waffle_flags.py: drop the three flag tests.views/tests/test_transcript_settings.py: addtest_transcript_upload_handler_returns_200_on_replace.This was missing on the fork — feat: Add transcript editor toggle and update related serializers and tests #267's tests only covered the toggle, so the 200-vs-201 upload
response change had no coverage. Added at the same location as upstream.
transcript_storage_handlers.py(the 200-on-replace change from #267) is unchanged.Parity check: the fork's net transcript-editor change after this PR (pre-#267 → this branch)
is line-for-line identical to the upstream PR's change set (28 lines each, zero diff).
Supporting information
() and the upstreaming-process Slack thread ().
Testing instructions
Manual:
GET /api/contentstore/v1/course_waffle_flags/<course_key>no longer returnsenable_transcript_editor; uploading a transcript for a language that already has one returns 200,a new language returns 201.