Skip to content

Revert "feat: incrementally load large assessment xblocks" - #446

Draft
santhosh-apphelix-2u wants to merge 1 commit into
release-ulmofrom
revert-445-incremental-assessment-load-v1
Draft

Revert "feat: incrementally load large assessment xblocks"#446
santhosh-apphelix-2u wants to merge 1 commit into
release-ulmofrom
revert-445-incremental-assessment-load-v1

Conversation

@santhosh-apphelix-2u

Copy link
Copy Markdown

Reverts #445

Copilot AI lite review requested due to automatic review settings August 28, 2026 00:09
@santhosh-apphelix-2u
santhosh-apphelix-2u marked this pull request as draft August 28, 2026 00:10

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts the previously introduced “incremental assessment load” feature, restoring the prior behavior where VerticalBlocks render all children server-side and removing the supporting API endpoint, settings, templates, toggles, and tests.

Changes:

  • Remove incremental child rendering in VerticalBlock and its template support for lazy placeholders.
  • Remove the /api/courseware/xblock_children/ endpoint and associated tests.
  • Remove related configuration (settings + waffle toggle) and helper logic in courseware rendering.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
xmodule/vertical_block.py Reverts eager/lazy split; renders all children inline again and removes lazy child metadata from template context.
openedx/core/djangoapps/courseware_api/views.py Removes XBlockChildren API view and related imports.
openedx/core/djangoapps/courseware_api/urls.py Removes the xblock_children route registration.
openedx/core/djangoapps/courseware_api/tests/test_views.py Removes tests for the deleted xblock_children endpoint.
lms/templates/vert_module.html Removes placeholder markup and bootstrap include used for incremental loading.
lms/templates/vert_module_lazy_bootstrap.html Deletes the JS bootstrap template for incremental loading.
lms/envs/common.py Removes incremental-load-related settings (INCREMENTAL_LOAD_*, XBLOCK_CHILDREN_BATCH_MAX).
lms/djangoapps/courseware/views/views.py Removes logic that opted large assessments into incremental loading via render context.
lms/djangoapps/courseware/toggles.py Removes the courseware.incremental_assessment_load waffle flag and helper.
lms/djangoapps/courseware/tests/test_incremental_render.py Deletes test coverage specific to the reverted feature.
lms/djangoapps/courseware/block_render.py Removes incremental-load helpers and the batch rendering implementation; restores original get_block_by_usage_id behavior/signature.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants