Revert "feat: incrementally load large assessment xblocks" - #446
Draft
santhosh-apphelix-2u wants to merge 1 commit into
Draft
Revert "feat: incrementally load large assessment xblocks"#446santhosh-apphelix-2u wants to merge 1 commit into
santhosh-apphelix-2u wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR reverts the previously introduced “incremental assessment load” feature, restoring the prior behavior where VerticalBlocks render all children server-side and removing the supporting API endpoint, settings, templates, toggles, and tests.
Changes:
- Remove incremental child rendering in
VerticalBlockand its template support for lazy placeholders. - Remove the
/api/courseware/xblock_children/endpoint and associated tests. - Remove related configuration (settings + waffle toggle) and helper logic in courseware rendering.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
xmodule/vertical_block.py |
Reverts eager/lazy split; renders all children inline again and removes lazy child metadata from template context. |
openedx/core/djangoapps/courseware_api/views.py |
Removes XBlockChildren API view and related imports. |
openedx/core/djangoapps/courseware_api/urls.py |
Removes the xblock_children route registration. |
openedx/core/djangoapps/courseware_api/tests/test_views.py |
Removes tests for the deleted xblock_children endpoint. |
lms/templates/vert_module.html |
Removes placeholder markup and bootstrap include used for incremental loading. |
lms/templates/vert_module_lazy_bootstrap.html |
Deletes the JS bootstrap template for incremental loading. |
lms/envs/common.py |
Removes incremental-load-related settings (INCREMENTAL_LOAD_*, XBLOCK_CHILDREN_BATCH_MAX). |
lms/djangoapps/courseware/views/views.py |
Removes logic that opted large assessments into incremental loading via render context. |
lms/djangoapps/courseware/toggles.py |
Removes the courseware.incremental_assessment_load waffle flag and helper. |
lms/djangoapps/courseware/tests/test_incremental_render.py |
Deletes test coverage specific to the reverted feature. |
lms/djangoapps/courseware/block_render.py |
Removes incremental-load helpers and the batch rendering implementation; restores original get_block_by_usage_id behavior/signature. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #445