[domwstarejwsi]

…install list

Summary by Sourcery

Bug Fixes:

• Ensure scheduled firmware updates exclude devices listed in the update exclusions input.

[coderabbitai]

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

• Bug Fixes
  • Scheduled firmware updates now exclude entities selected in the update exclusion list.

The scheduled firmware update sequence now filters entities in input_update_exclusions before it builds the pending firmware update list.

Changes: Firmware update exclusions

Layer / File(s)	Summary
Filter pending updates blueprints/automation/EdwardTFN/auto_update_scheduled.yaml	The pending firmware update list now excludes entities in input_update_exclusions.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: edwardtfn

Merge Risk: Minimal · up to d884a

The firmware install list now applies the existing exclusion filter consistently. No actionable merge-blocking risk was identified.

Pre-merge checks: 4 · 1

Failed checks: 1 inconclusive

Check name	Status	Explanation	Resolution
Description check		The description refers to the install list, which relates to the changeset, but it is an incomplete and very vague fragment.	Provide a complete description that states that the scheduled auto-update process now applies update_exclusions when it builds the Devices firmware install list.

Passed checks: 4 passed

Check name	Status	Explanation
Title check		The title identifies the scheduled firmware update change and states that update_exclusions must apply to the Devices firmware install list.
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

_{A rabbit checks the update queue,
And skips the names marked not to do.
The pending list grows neat and small,
No excluded device joins the call.
Then off the rabbit hops, pleased through.}

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: c88068cc-bab6-4cf6-bceb-476d3aaebb5a

Commits

Reviewing files that changed from the base of the PR and between ae221db and d884a15.

Files selected for processing: 1

• blueprints/automation/EdwardTFN/auto_update_scheduled.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The scheduled firmware update automation now respects configured update exclusions by removing excluded entities from the pending update list before installation.

Flow diagram for scheduled firmware update exclusions

flowchart TD
    A[Pending update entities] --> B[Filter to firmware_update_entities]
    B --> C[Reject input_update_exclusions]
    C --> D[Install remaining firmware updates]

Loading

File-Level Changes

Change	Details	Files
Exclude configured firmware update entities from the scheduled installation list.	Filter pending, enabled firmware updates against the configured update-exclusions input before building the installation list.	blueprints/automation/EdwardTFN/auto_update_scheduled.yaml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook