Generalize Mat×Vec operator* to support mixed scalar types - #9
Merged
Conversation
csparker247
marked this pull request as draft
August 25, 2025 13:22
csparker247
force-pushed
the
generalize-mat-vec
branch
from
August 25, 2025 13:45
411e4cf to
d699f1c
Compare
csparker247
force-pushed
the
generalize-mat-vec
branch
from
August 25, 2025 13:50
d699f1c to
139481f
Compare
csparker247
marked this pull request as ready for review
March 20, 2026 23:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The matrix-vector
operator*was overly generic, accepting anyVectortype, which obscured intent and prevented mixed-type scalar multiplication.Changes
Mat.hpp: Replace unconstrainedVectortemplate parameter with explicitVec<T2, N>, returningVec<T1, N>(matrix scalar type). Enables multiplying aMat<M,N,T1>by aVec<T2,N>with differing scalar types.Mat.hpp: Remove spurious trailing semicolon from default constructor.String.hpp: Take structured binding byconst&insplit()range loop to avoid unnecessary copies.