🧹 [Code health improvement] Extract tmp_path_for and atomic_write - #21
🧹 [Code health improvement] Extract tmp_path_for and atomic_write#21edithatogo wants to merge 1 commit into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
🎯 What: The code health issue addressed is code duplication around the
tmp_path_forfunction and the atomic write pattern (save_atomic/write_parquet_atomic) insrc/catalog.rs,src/quality.rsandsrc/pipeline.rs.💡 Why: How this improves maintainability is by extracting these common patterns into a new
src/utils.rsmodule, which removes redundant code and ensures consistency across modules whenever an atomic write is performed.✅ Verification: Ran
cargo testcompletely successfully, and also ranrustfmton the modified files to ensure styling remains intact.✨ Result: The code is cleaner, and any future modules that require safe atomic file writing can now reuse
utils::atomic_writewithout re-implementing the same tmp file fallback and copy/rename logic.PR created automatically by Jules for task 3016069770342254630 started by @edithatogo