🔒 Fix XSS vulnerability in HTML report generation - #104
Conversation
🎯 What: The `generate_html_report.py` script was directly interpolating `os.path.basename(ex)` and `results_text` into HTML output without escaping it.⚠️ Risk: If a malicious SHACL rule produces an unescaped HTML string in the results or if an example file has a malicious filename, this script would generate a report vulnerable to Cross-Site Scripting (XSS), compromising the viewer of the report. 🛡️ Solution: Used `html.escape()` to sanitize untrusted input before rendering it in the HTML string.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
1 participant
🎯 What: The
⚠️ Risk: If a malicious SHACL rule produces an unescaped HTML string in the results or if an example file has a malicious filename, this script would generate a report vulnerable to Cross-Site Scripting (XSS), compromising the viewer of the report.
generate_html_report.pyscript was directly interpolatingos.path.basename(ex)andresults_textinto HTML output without escaping it.🛡️ Solution: Used
html.escape()to sanitize untrusted input before rendering it in the HTML string. Also added a unit test to verify that the output HTML is properly escaped.PR created automatically by Jules for task 9366146250231928287 started by @edithatogo