feat: Add Solid.Tag.put/3 and remove/2 helpers#173
Open
google-labs-jules[bot] wants to merge 2 commits intomainfrom
Open
feat: Add Solid.Tag.put/3 and remove/2 helpers#173google-labs-jules[bot] wants to merge 2 commits intomainfrom
google-labs-jules[bot] wants to merge 2 commits intomainfrom
Conversation
This commit introduces two new helper functions to the `Solid.Tag` module: `put/3` and `remove/2`. These functions provide a more convenient and fluent way to manipulate the map of tags used by the Solid parser. - `Solid.Tag.put/3`: Adds a new tag to the tags map. - `Solid.Tag.remove/2`: Removes a tag from the tags map. Both functions accept either an atom or a string as the tag name, providing more flexibility to the developer. This change allows for a more readable and chainable syntax for customizing tags, as requested in the original issue. For example: ```elixir Solid.Tag.default_tags() |> Solid.Tag.put(:current_line, CustomTags.CurrentLine) |> Solid.Tag.remove(:comment) ```
This commit updates the `README.md` file to use the new `Solid.Tag.put/3` and `Solid.Tag.remove/2` helper functions in the examples for adding and removing custom tags. This makes the documentation more consistent with the new, more fluent API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces two new helper functions to the
Solid.Tagmodule:put/3andremove/2. These functions provide a more convenient and fluent way to manipulate the map of tags used by the Solid parser.