Repository navigation
fix: move file list into its own registry item - #301
Merged
Merged
Conversation
Upload button usage and block, and file field, imported FileList/FileListItem from multi-file without the matching registry dependency. Extract FileBadge, FileListItem and FileList into file-list.tsx with a file-list registry item. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
raviships
marked this pull request as ready for review
October 13, 2026 11:38
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Upload Button docs Usage example and
upload-button-blockimportFileListfrom@/components/upload/multi-file, butupload-button.jsondoesn't installmulti-file. So copying the documented usage afternpx shadcn add .../upload-button.jsonfails with a missing module.file-fieldhad the same coupling but declared it, which meant installing it pulled in the wholeFileUploaderjust forFileListItem.FileBadge,FileListItemandFileListmove unchanged frommulti-file.tsxinto a newfile-list.tsxwith its ownfile-listregistry item:Docs:
components/file-listpage, added to the sidebar and the agent-docs selection.file-listand shows the install command.file-list.docs/src/components/upload/copies anddocs/public/r/are regenerated (pnpm registry:build).No changeset: registry components aren't part of a published
@edgestore/*package.Evidence
pnpm registry:buildsucceeds and emitsdocs/public/r/file-list.json.pnpm agent-docs:testpasses.tsc --noEmitinexamples/componentsanddocsreports no errors in the touched upload files. Other errors in those projects come from@edgestore/*packages not being built in the worktree.pnpm agent-docs:check/pnpm agent-docs:pack-check, which need a fullpnpm buildfirst.Risk and rollback
Door: Two-way. Reverting restores the old file layout and registry JSON.
Blast radius:
multi-file.tsxkeep a self-contained copy and are unaffected.file-uploaderorfile-fieldvia the CLI now also installscomponents/upload/file-list.tsx.FileList/FileListItem/FileBadgefrom a freshly re-installedmulti-file.tsxmust switch tofile-list.🤖 Generated with Claude Code