Skip to content

fix: move file list into its own registry item - #301

Merged
raviships merged 1 commit into
mainfrom
t3code/decouple-button-upload
Oct 13, 2026
Merged

raviships merged 1 commit into
mainfrom
t3code/decouple-button-upload

Conversation

@raviships

Copy link
Copy Markdown
Collaborator

Summary

The Upload Button docs Usage example and upload-button-block import FileList from @/components/upload/multi-file, but upload-button.json doesn't install multi-file. So copying the documented usage after npx shadcn add .../upload-button.json fails with a missing module. file-field had the same coupling but declared it, which meant installing it pulled in the whole FileUploader just for FileListItem.

FileBadge, FileListItem and FileList move unchanged from multi-file.tsx into a new file-list.tsx with its own file-list registry item:

 file-uploader        → button, dropzone, uploader-provider, upload-utils
-                       + progress-bar
+                       + file-list
 file-field           → dropzone, uploader-provider, upload-utils
-                       + file-uploader
+                       + file-list
 upload-button-block  → upload-button, dropzone, uploader-provider
-                       + file-uploader
+                       + file-list
+file-list            → progress-bar, uploader-provider, upload-utils
 upload-button        → (unchanged; the button never uses the list)

Docs:

  • New components/file-list page, added to the sidebar and the agent-docs selection.
  • Upload Button Usage now says it also needs file-list and shows the install command.
  • Multi-file and File Field manual-install steps point to file-list.
  • docs/src/components/upload/ copies and docs/public/r/ are regenerated (pnpm registry:build).

No changeset: registry components aren't part of a published @edgestore/* package.

Evidence

  • pnpm registry:build succeeds and emits docs/public/r/file-list.json.
  • pnpm agent-docs:test passes.
  • Prettier is clean on all touched files.
  • tsc --noEmit in examples/components and docs reports no errors in the touched upload files. Other errors in those projects come from @edgestore/* packages not being built in the worktree.
  • Not run: pnpm agent-docs:check / pnpm agent-docs:pack-check, which need a full pnpm build first.

Risk and rollback

Door: Two-way. Reverting restores the old file layout and registry JSON.
Blast radius:

  • Users who already copied multi-file.tsx keep a self-contained copy and are unaffected.
  • Re-adding file-uploader or file-field via the CLI now also installs components/upload/file-list.tsx.
  • Code that imported FileList/FileListItem/FileBadge from a freshly re-installed multi-file.tsx must switch to file-list.

By: Claude Opus 5.5 on Claude Code

🤖 Generated with Claude Code

Upload button usage and block, and file field, imported FileList/FileListItem
from multi-file without the matching registry dependency. Extract FileBadge,
FileListItem and FileList into file-list.tsx with a file-list registry item.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@raviships
raviships marked this pull request as ready for review October 13, 2026 11:38
@vercel

vercel Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
edgestore-docs Ready Ready Preview Oct 13, 2026 11:39am UTC
example-access-control Ready Ready Preview Oct 13, 2026 11:39am UTC
example-components Ready Ready Preview Oct 13, 2026 11:39am UTC

Request Review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T11:42:49.110313Z d1d0b42 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

This branch was successfully deployed

3 active deployments
Preview – edgestore-docs — d1d0b425 Deployed Oct 13, 2026 by vercel[bot]
Preview – example-access-control — d1d0b425 Deployed Oct 13, 2026 by vercel[bot]
Preview – example-components — d1d0b425 Deployed Oct 13, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant