Skip to content

Add s3 storage - #106

Merged
jayvdb merged 4 commits into
mainfrom
s3
Aug 6, 2026
Merged

Add s3 storage#106
jayvdb merged 4 commits into
mainfrom
s3

Conversation

@jayvdb

@jayvdb jayvdb commented Aug 5, 2026

Copy link
Copy Markdown
Member

No description provided.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3fe8ea5c-11da-4b7d-8655-ca46134b5c49

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@deepsource-io

deepsource-io Bot commented Aug 5, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in d8d42f9...9694fe1 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Coverage  

Code Review Summary

Analyzer Status Updated (UTC) Details
C# Aug 5, 2026 8:56p.m. Review ↗
C & C++ Aug 5, 2026 8:56p.m. Review ↗
Docker Aug 5, 2026 8:56p.m. Review ↗
Java Aug 5, 2026 8:56p.m. Review ↗
JavaScript Aug 5, 2026 8:56p.m. Review ↗
Python Aug 5, 2026 8:56p.m. Review ↗
Rust Aug 5, 2026 8:56p.m. Review ↗
Secrets Aug 5, 2026 8:56p.m. Review ↗
Code coverage Aug 5, 2026 9:29p.m. Review ↗

Code Coverage Summary

Language Line Coverage (New Code) Line Coverage (Overall)
Aggregate
95.5%
58.3%
[▲ up 0.2% from main]
Python -
89.1%
Rust
95.5%
55.8%
[▲ up 0.2% from main]

➟ Additional coverage metrics may have been reported. See full coverage report ↗


Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 18 complexity · 2 duplication

Metric Results
Complexity 18
Duplication 2

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.02985% with 4 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
services/storage/src/routes.rs 91.66% 2 Missing and 1 partial ⚠️
services/storage/src/lib.rs 96.15% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@jayvdb
jayvdb marked this pull request as ready for review August 5, 2026 22:18
@jayvdb
jayvdb requested a review from pierre-tenedero August 5, 2026 23:54
@jayvdb
jayvdb merged commit 72ed322 into main Aug 6, 2026
38 of 40 checks passed
@jayvdb
jayvdb deleted the s3 branch August 6, 2026 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants