Repository navigation
Do not define __BLOCKS__ with macOS Clang [GH #307] - #308
Merged
Merged
Conversation
daveedvdv-nvidia
force-pushed
the
0005
branch
from
October 16, 2026 15:27
7173149 to
52a125e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the definitions of
__BLOCKS__since we cannot parse the(^)format, causing any TU that includes<stdlib.h>to break (which is a fair number of the libc++ STL headers).Separate from the core of the PR, add .DS_Store to the gitignore since they're an annoyance of using macOS
Closes: #307