Skip to content

fix(electronics): empty 'Start blank' + wire tool connects to pins #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ecto merged 2 commits into from
Jun 5, 2026
Merged

fix(electronics): empty 'Start blank' + wire tool connects to pins #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cdd283
fix(onboarding): "Start blank" gives a truly empty canvas
ecto Jun 5, 2026
76dd1e2
fix(electronics): let the wire tool connect to component pins
ecto Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions packages/app/src/components/InlineOnboarding.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import { Waveform } from "@phosphor-icons/react/dist/ssr/Waveform";
import { Star } from "@phosphor-icons/react/dist/ssr/Star";
import type { Icon } from "@phosphor-icons/react";
import { cn } from "@/lib/utils";
import { useDocumentStore, useUiStore, useChatStore, parseVcadFile } from "@vcad/core";
import { useDocumentStore, useChatStore, parseVcadFile } from "@vcad/core";
import { useAuth, isAuthEnabled, AuthModal } from "@vcad/auth";
import { useOnboardingStore } from "@/stores/onboarding-store";
import { examples, exampleToVcadFile } from "@/data/examples";
Expand Down Expand Up @@ -51,9 +51,6 @@ export function InlineOnboarding({ visible }: InlineOnboardingProps) {
const fileInputRef = useRef<HTMLInputElement>(null);

const loadDocument = useDocumentStore((s) => s.loadDocument);
const addPrimitive = useDocumentStore((s) => s.addPrimitive);
const select = useUiStore((s) => s.select);
const setTransformMode = useUiStore((s) => s.setTransformMode);
const setChatOpen = useChatStore((s) => s.setOpen);
const incrementProjectsCreated = useOnboardingStore(
(s) => s.incrementProjectsCreated,
Expand Down Expand Up @@ -95,10 +92,8 @@ export function InlineOnboarding({ visible }: InlineOnboardingProps) {
}

function handleStartBlank() {
// "empty canvas" — start with a truly blank scene (no stray primitive).
incrementProjectsCreated();
const partId = addPrimitive("cube");
select(partId);
setTransformMode("translate");
hide();
}

Expand Down
4 changes: 4 additions & 0 deletions packages/app/src/components/electronics/SchematicCanvas.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,6 +605,10 @@ export function SchematicCanvas() {

const onComponentClick = useCallback(
(e: React.MouseEvent, idx: number, ref: string) => {
// Wire tool: let the click fall through to the canvas handler so it snaps
// to this component's pin — clicking a pin should start/finish a wire, not
// select the part. (Without this, stopPropagation swallows the wire click.)
if (schTool === "wire") return;
e.stopPropagation();
if (schTool === "delete") {
removeSchematicComponent(idx);
Expand Down