Add regression fixture for readonly promoted properties#54
Merged
TomasVotruba merged 1 commit intoJul 20, 2026
Merged
Conversation
TomasVotruba
enabled auto-merge (squash)
July 20, 2026 09:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported case: constructor with 3
private readonlypromoted properties on a single line was suspected of not being split.Verified
StandaloneLinePromotedPropertyFixeralready handles it — this adds a fixture to lock the behavior in.final class ReadonlyPromotedProperties { - public function __construct(private readonly EntityManager $entityManager, private readonly SchedulerPlanner $schedulerPlanner, private readonly SchedulerRepository $schedulerRepository) + public function __construct( + private readonly EntityManager $entityManager, + private readonly SchedulerPlanner $schedulerPlanner, + private readonly SchedulerRepository $schedulerRepository + ) { } }Note for anyone hitting this: the rule sits at index 17 of
SpacesLevel::RULES, sowithSpacesLevel()below 17 never loads it.