Hotfix/file_resource_script_generation#46
Merged
Conversation
|
|
tbkr
force-pushed
the
hotfix/resource-script-generation
branch
13 times, most recently
from
2e98378 to
ef8fd98
Compare
tbkr
force-pushed
the
hotfix/resource-script-generation
branch
16 times, most recently
from
c35578a to
d872fe9
Compare
tbkr
force-pushed
the
hotfix/resource-script-generation
branch
3 times, most recently
from
cfd3d11 to
d62c139
Compare
Collaborator
|
@tbkr, thanks for this contribution! I never really used the resource feature of pyflow. Could you just add a test for the Resource class? |
tbkr
force-pushed
the
hotfix/resource-script-generation
branch
from
169f10d to
f7caf93
Compare
tbkr
changed the title
tbkr
force-pushed
the
hotfix/resource-script-generation
branch
4 times, most recently
from
dab0d83 to
85217b3
Compare
Contributor
Author
|
@corentincarton I added a test case for the resource file creation and also for the use case of deploying it to several hosts. Could you have a look? |
colonesej
force-pushed
the
hotfix/resource-script-generation
branch
from
5a76146 to
3b603b5
Compare
colonesej
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When working with marsflow I encountered problems with the
pf.FileResourceclass which was mainly due to the reason that the internals of the resource class have changed.I enabled moved the assignment of the
server_filenameto the constructor of thepf.FileResourceclass and adjusted other occurrences.In case my changes broke the intended architecture, feel free to comment.