Add std::hash specializations for Date, Time, DateTime#278
Draft
Add std::hash specializations for Date, Time, DateTime#278
Conversation
Allow Date, Time, and DateTime to be used as keys in std::unordered_map and std::unordered_set by providing std::hash specializations in each type's header. Date hashes via julian(), Time via hhmmss() (avoiding floating-point hash pitfalls on the underlying double), and DateTime combines both using a new hash_combine utility. Requires ecbuild fix for sg.pl to handle template <> syntax. Fixes: ECKIT-561 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #278 +/- ##
===========================================
+ Coverage 66.38% 66.41% +0.02%
===========================================
Files 1127 1128 +1
Lines 57792 57829 +37
Branches 4408 4408
===========================================
+ Hits 38366 38406 +40
+ Misses 19426 19423 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow Date, Time, and DateTime to be used as keys in std::unordered_map and std::unordered_set by providing std::hash specializations in each type's header.
Date hashes via julian(), Time via hhmmss() (avoiding floating-point hash pitfalls on the underlying double), and DateTime combines both using a new hash_combine utility.
Requires ecbuild fix for sg.pl to handle template <> syntax.
Fixes: ECKIT-561
NOTE: blocked by a bug in ecbuild/sg.pl ecmwf/ecbuild#134
Contributor Declaration
By opening this pull request, I affirm the following:
🌦️ >> Documentation << 🌦️
https://sites.ecmwf.int/docs/dev-section/eckit/pull-requests/PR-278