Replace concatenates Strings by Text-Blocks in CompilerTests#2991
Replace concatenates Strings by Text-Blocks in CompilerTests#2991HannesWell wants to merge 1 commit intoeclipse-xtext:mainfrom
Conversation
HannesWell
force-pushed
the
text-blocks_in_compilerTests
branch
from
21af390 to
952f634
Compare
| <attribute name="test" value="true"/> | ||
| </attributes> | ||
| </classpathentry> | ||
| <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-11/"/> |
There was a problem hiding this comment.
am not sure if i am ok with that just for the test
There was a problem hiding this comment.
This PR aims to the time, when Java-17 is already the required minimum. I assumed this will the case as soon Java-21 is supported? So this is actually a draft.
If you are interested in a PR that bumps the required Java-version for all bundles, I can provide one just for that.
HannesWell
force-pushed
the
text-blocks_in_compilerTests
branch
from
952f634 to
659d9cc
Compare
|
Since the test projects require Java-17 in the meantime, this should be ready. |
Test Results 6 461 files ±0 6 461 suites ±0 3h 9m 18s ⏱️ - 7m 26s For more details on these failures and errors, see this check. Results for commit 0cfd535. ± Comparison against base commit 4a6daa0. ♻️ This comment has been updated with latest results. |
|
I seem to understand that the Jenkins build fails because it's referring to a non-existent TP. |
This improves the readability of Strings defining the test-input and expected output. It avoids the need to explicitly add new-line characters and the need to escape double-quotes.
HannesWell
force-pushed
the
text-blocks_in_compilerTests
branch
from
659d9cc to
0cfd535
Compare
3 participants
This improves the readability of Strings defining the test-input and expected output. It avoids the need to explicitly add new-line characters and the need to escape double-quotes.
Currently the tests require only Java-11, but it was said that as part of #2686 Java-17 will be the required minimum.