docs: document assertComplete and assertFailure for Future-based tests - #168
docs: document assertComplete and assertFailure for Future-based tests#168arimu1 wants to merge 1 commit into
Conversation
|
Updated docs per review: removed the incorrect claim that |
|
Rewrote commits to use my Eclipse-linked email ( |
93e7ff6 to
3553379
Compare
|
Temporarily closing to re-trigger Eclipse ECA validation after rewriting author email + Signed-off-by. |
|
ECA still fails because Eclipse has no account for Next step for me: create/login at https://accounts.eclipse.org with that email, sign the ECA at https://accounts.eclipse.org/user/eca, link GitHub |
ba6e2c1 to
0937d0f
Compare
|
@eclipse-fdn-bot recheck |
Document VertxTestContext.assertComplete / assertFailure for Future-based tests, including that they only failNow on the unexpected outcome and do not create checkpoints (tests still need completeNow or a checkpoint). Fixes eclipse-vertx#140 Signed-off-by: arimu1 <af.nawfal@gmail.com>
0937d0f to
74a6de0
Compare
|
@eclipse-fdn-bot recheck |
Summary
VertxTestContext#assertCompleteand#assertFailurein the module manual (index.adoc).usingAssertComplete,usingAssertFailure) included via docgen, matching existing style.Handler<AsyncResult<T>>testing.Fixes #140
Test plan
Examplestests and unit tests inVertxTestContextTest.{@link examples.Examples#...}includes and callout markers consistent with neighboring sections.Contributor note
Eclipse Contributor Agreement (ECA) will be signed by the human contributor before merge.
Made with Cursor