Skip to content

feat(test): add support to run test on a Virtual Thread - #144

Open
cristian-joseb wants to merge 6 commits into
eclipse-vertx:masterfrom
cristian-joseb:feat/virtualThread
Open

feat(test): add support to run test on a Virtual Thread#144
cristian-joseb wants to merge 6 commits into
eclipse-vertx:masterfrom
cristian-joseb:feat/virtualThread

Conversation

@cristian-joseb

@cristian-joseb cristian-joseb commented Jan 13, 2025

Copy link
Copy Markdown

Motivation:

Allowing to run unit test using Virtual Thread and a Sync programing model.

When running unit test in Virtual Thread get an error, because the extension is working on a Event loop context, this change will allow to pass a ThreadingModel to run the unit test, while keeping the Event Loop threading model as default.

@vietj vietj added this to the 5.0.0 milestone Jan 13, 2025
@vietj

vietj commented Jan 13, 2025

Copy link
Copy Markdown
Member

can you sign the Eclipse Contributor Agreement @cristian-joseb ?

@cristian-joseb

Copy link
Copy Markdown
Author

can you sign the Eclipse Contributor Agreement @cristian-joseb ?

done

Comment thread src/main/java/io/vertx/junit5/RunTestOnContext.java
Comment thread src/main/java/io/vertx/junit5/RunTestOnContext.java
Comment thread src/main/java/io/vertx/junit5/RunTestOnContext.java

@vietj vietj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few changes are necessary

@cristian-joseb
cristian-joseb requested a review from vietj January 29, 2025 19:16
@vietj vietj modified the milestones: 5.0.0, 5.1.0 May 14, 2025
@mcollins-ttd

Copy link
Copy Markdown

Are there any more changes required?

@vietj

vietj commented Nov 14, 2025

Copy link
Copy Markdown
Member

it should have been merged indeed

@vietj vietj modified the milestones: 5.1.0, 5.1.1, 5.1.2 May 31, 2026
@vietj vietj modified the milestones: 5.1.2, 5.1.3 Jun 8, 2026
@vietj vietj modified the milestones: 5.1.3, 5.1.4 Jun 23, 2026
@vietj vietj modified the milestones: 5.1.4, 5.1.5, 5.1.6 Jul 7, 2026
@vietj vietj modified the milestones: 5.1.6, 5.1.7 Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants