Skip to content

[POC] feat: scaffold Tariffs KIT at Sandbox maturity#1505

Draft
Copilot wants to merge 4 commits intomainfrom
copilot/create-tariffs-kit
Draft

[POC] feat: scaffold Tariffs KIT at Sandbox maturity#1505
Copilot wants to merge 4 commits intomainfrom
copilot/create-tariffs-kit

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 13, 2026

Caution

Don't merge this, is only a proof of concept!

👋 Hi! I'm the KIT Master Builder — your Eclipse Tractus-X KIT architect.

Adds a first example "Tariffs KIT" — a Catena-X KIT for standardized exchange of tariff classifications, HS/CN codes, and duty-relevant product data across global supply chains.

New files — docs-kits/kits/tariffs-kit/

  • changelog.md — initial 0.1.0 entry
  • adoption-view/adoption-view.md — vision/mission, business context (Mermaid flow), use cases (HS code sharing, preferential origin, sourcing analysis), personas, standards table
  • development-view/development-view.md — Mermaid sequence diagram (request/response flow), JSON semantic model stubs for tariff request & response, protocols table
  • resources/REUSE.toml — CC-BY-4.0 annotation for resources dir

Logo — static/img/kits/tariffs/

  • tariffs-kit-raw-logo.svg — white monochrome scale/balance icon
  • tariffs-kit-raw-logo.svg.license — CC-BY-4.0 sidecar

Registration

  • data/kitsData.js — imports TariffsKitLogo; adds master data entry under useCases (Supply Chain domain, Sandbox/draft, latestVersion: '0.1.0')
  • sidebarsDocsKits.js — inserts 'Tariffs KIT' category alphabetically before 'Traceability KIT'

All .md files carry CC-BY-4.0 headers and ## NOTICE footers (TRG 7.07); diagrams are Mermaid (TRG 1.04); Kit3DLogo rendered on every page.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: matbmoser <71728767+matbmoser@users.noreply.github.com>
Copilot AI changed the title [WIP] Add Tariffs KIT for better pricing management feat: scaffold Tariffs KIT at Sandbox maturity Mar 13, 2026
Copilot AI requested a review from matbmoser March 13, 2026 10:51
@matbmoser matbmoser requested a review from Copilot March 13, 2026 10:54
@matbmoser matbmoser changed the title feat: scaffold Tariffs KIT at Sandbox maturity [POC] feat: scaffold Tariffs KIT at Sandbox maturity Mar 13, 2026
@matbmoser
Copy link
Copy Markdown
Contributor

@copilot review this PR.

…dence)

Co-authored-by: matbmoser <71728767+matbmoser@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 13, 2026

@copilot review this PR.

👋 I'm the KIT Master Builder — here's my full review of this PR.


✅ What I Like

  • Frontmatter complete on all three pages (id, title, description, sidebar_position) ✅
  • CC-BY-4.0 copyright header present after frontmatter in every .md file ✅
  • ## NOTICE footer present at the bottom of every .md file ✅
  • Kit3DLogo component imported and rendered in all three pages ✅
  • Changelog follows Keep a Changelog format with a valid 0.1.0 entry ✅
  • Diagrams as code — both Mermaid graph LR (adoption view) and sequenceDiagram (development view) — no screenshots ✅
  • Sandbox route correctly uses /docs-kits/next/kits/tariffs-kit/... prefix ✅
  • logoLicencse field uses the intentional codebase typo correctly ✅
  • SVG logo is white/monochrome with transparent background and no text claims ✅
  • Logo .license sidecar present with correct CC-BY-4.0 attribution ✅
  • Sidebar entry is alphabetically correct: Supply Chain Disruption → Tariffs → Traceability ✅
  • Description length: 118 characters (within the 10–500 schema constraint) ✅
  • ID uniqueness: tariffs appears exactly once across all kitsData.js arrays ✅
  • markdownlint: 0 errors on all 3 files ✅
  • kitNavItems.js was correctly regenerated (tariffs KIT appears in nav) ✅

⚠️ Fix I Applied

resources/REUSE.toml — The original file used path = "**" (too broad, would annotate the REUSE.toml itself as CC-BY-4.0) and was missing precedence = "closest". Every other kit in the codebase uses specific extension patterns. Fixed in commit be7a8b9:

# Before (non-standard):
path = "**"

# After (matches all other kits like due-diligence-check-kit, ai-service-kit):
path = ["*.png", "*.jpg", "*.jpeg", "*.svg"]
precedence = "closest"

💡 Suggestions for When This Graduates from Sandbox

These are not blocking for the Sandbox level but should be addressed before Incubating:

  1. Real SAMM .ttl files — The semantic models are currently JSON stubs in the development view. A proper TariffDataRequest.ttl and TariffDataResponse.ttl will be needed.
  2. Replace placeholder logo — The SVG balance-scale icon is a placeholder. Commission a proper design matching the Tractus-X KIT logo family.
  3. CODEOWNERS entry — Required when moving to Incubating-In Review. Add docs-kits/kits/tariffs-kit/ @<eclipse-committer-username> to .github/CODEOWNERS.
  4. industries field — Currently set to ['automotive']. Tariffs are cross-industry — consider broadening to ['automotive', 'construction', 'manufacturing'] as the use case expands.
  5. CX standard references — Replace the placeholder CX-0001/CX-0018 references with the actual Catena-X notification standard numbers once the SAMM is registered.

📋 Compliance Checklist (Sandbox level)

Check Status
Frontmatter complete
CC-BY-4.0 header
NOTICE footer
Kit3DLogo rendered
Changelog with version entry
Diagrams as code (TRG 1.04)
SVG logo + .license sidecar
Master data entry (kitsData.js)
Sidebar entry (alphabetical)
REUSE.toml (fixed)
ID unique across all arrays
Sandbox route prefix
markdownlint 0 errors

Overall: This is a solid Sandbox KIT scaffold. The one formatting issue I found (REUSE.toml) has been fixed in be7a8b9. Ready for the next iteration when the domain experts provide real content! 🏗️

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR scaffolds a new Tariffs KIT at Sandbox maturity, adding initial KIT documentation, logo assets, and registering the KIT in the site’s master data and navigation.

Changes:

  • Added Tariffs KIT documentation pages (changelog, adoption view, development view) and a resources REUSE file.
  • Added a new Tariffs KIT logo SVG plus .license sidecar.
  • Registered the KIT in data/kitsData.js, sidebarsDocsKits.js, and regenerated nav items.

Reviewed changes

Copilot reviewed 7 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
utils/generated/kitNavItems.js Regenerated nav items to include the new Tariffs KIT entry.
static/img/kits/tariffs/tariffs-kit-raw-logo.svg Adds the Tariffs KIT SVG logo asset.
static/img/kits/tariffs/tariffs-kit-raw-logo.svg.license Adds CC-BY-4.0 license sidecar metadata for the logo.
sidebarsDocsKits.js Adds Tariffs KIT to the docs sidebar navigation.
docs-kits/kits/tariffs-kit/resources/REUSE.toml Introduces REUSE annotations for Tariffs KIT resources.
docs-kits/kits/tariffs-kit/development-view/development-view.md Adds the initial Development View content and diagrams/models.
docs-kits/kits/tariffs-kit/changelog.md Adds initial changelog for version 0.1.0.
docs-kits/kits/tariffs-kit/adoption-view/adoption-view.md Adds the initial Adoption View content and diagrams/tables.
data/kitsData.js Imports the new logo and registers the Tariffs KIT master data entry (Sandbox).
Comments suppressed due to low confidence (2)

docs-kits/kits/tariffs-kit/resources/REUSE.toml:10

  • path is defined as a string ("**") and the annotation is missing precedence = "closest". Elsewhere in the repo, REUSE.toml uses an array for path (e.g., ["*.png", ...]) and sets precedence. Align this file to the same structure so REUSE tooling interprets the annotation consistently.
SPDX-License-Identifier = "CC-BY-4.0"

data/kitsData.js:794

  • There is inconsistent indentation after the new tariffs KIT entry (}, followed by an extra-indented {). Please normalize the indentation to match the surrounding array entries to keep kitsData.js readable and reduce diff noise.
    },
      {
      id: 'osim',
      name: 'ONLINE SIMULATION KIT',

Comment on lines +761 to +764
id: 'tariffs',
name: 'TARIFFS KIT',
logo: TariffsKitLogo,
logoLicencse: {
Comment on lines +964 to +966
'kits/tariffs-kit/changelog',
'kits/tariffs-kit/adoption-view/adoption-view',
'kits/tariffs-kit/development-view/development-view'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Inbox

Development

Successfully merging this pull request may close these issues.

3 participants