Skip to content

Conversation

@mcharfadi
Copy link
Contributor

@mcharfadi mcharfadi commented Jan 26, 2026

Bug: #1870

PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW

Auto review

  • Have you reviewed this PR? Please do a first quick review, It is very useful to detect typos and missing copyrights, check comments, check your code... The reviewer will thank you for that :)

Project management

  • Has the pull request been added to the relevant milestone?
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, type:)
  • Have the relevant issues been added to the same project milestone as the pull request?

Changelog and release notes

  • Has the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc?
  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc?
  • In case of a change with a visual impact, are there any screenshots in the doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a key change, has the change been added to Key highlights section in doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?

Documentation

  • Have you included an update of the documentation in your pull request? Please ask yourself if an update (installation manual, user manual, developer manual...) is needed and add one accordingly.

Tests

  • Is the code properly tested? Any pull request (fix, enhancement or new feature) should come with a test (or several). It could be unit tests, integration tests or cypress tests depending on the context. Only doc and releng pull request do not need for tests.

@mcharfadi mcharfadi added this to the 2026.1.0 milestone Jan 26, 2026
@mcharfadi mcharfadi requested a review from AxelRICHARD January 26, 2026 09:05
@mcharfadi mcharfadi linked an issue Jan 26, 2026 that may be closed by this pull request
@mcharfadi mcharfadi force-pushed the mch/fix/drop-node-visibility branch 2 times, most recently from 2f288ab to 61e948e Compare January 26, 2026 09:20
@AxelRICHARD AxelRICHARD modified the milestones: 2026.1.0, 2026.3.0 Jan 28, 2026
Bug: #1870
Signed-off-by: Michaël Charfadi <michael.charfadi@obeosoft.com>
@AxelRICHARD AxelRICHARD force-pushed the mch/fix/drop-node-visibility branch from 61e948e to faf3a41 Compare January 29, 2026 09:59
@AxelRICHARD AxelRICHARD merged commit 394d222 into main Jan 29, 2026
8 checks passed
@AxelRICHARD AxelRICHARD deleted the mch/fix/drop-node-visibility branch January 29, 2026 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not display compartments when an Element is dropped on a diagram

3 participants