Skip to content

Conversation

@MaciejKaszynski
Copy link

  • Currently the IP address of the QEMU VM is hard-coded as the parameter has the default value that is never set this adds an optional config field host_ip.
    • This is backward compatible as the default will still be the old IP address.
  • For the QEMU instance also made the second network device optional and dependent on having the host_diagnostic_ip optional configuration field.
  • Made the data_router_config configuration field optional so that if nothing is configured no dlt is created.
  • Made all the targets take in an ECU config as a parameter instead of having each config field as a parameter.

target.teardown()
dlt = None
if target_config.data_router_config:
dlt = DltReceive(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing with. DltReceive is context manager. In other targets as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants