-
Notifications
You must be signed in to change notification settings - Fork 148
Add preference page for console icon update #2435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It seems kind of "lost at the end" of the preferences. Personally I think it would be better next to the "Pin..." preference. |
Test Results1 318 files - 659 1 318 suites - 659 1h 1m 4s ⏱️ - 31m 10s Results for commit 19c55cd. ± Comparison against base commit 56e8969. This pull request skips 25 tests.♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adds a user preference to enable/disable dynamic updating of the Console view icon based on the currently active console page (Fixes #2434).
Changes:
- Add a new Console preference key and default value for icon auto-update.
- Add a checkbox to the Console preference page to control icon auto-update.
- Gate ConsoleView icon updates based on the new preference.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ConsoleView.java | Checks the new preference to decide whether to use the dynamic per-console icon or the default icon. |
| debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ConsoleUIPreferenceInitializer.java | Sets the default value for the new preference (enabled). |
| debug/org.eclipse.ui.console/src/org/eclipse/ui/console/IConsoleConstants.java | Introduces the new preference constant in the public constants interface. |
| debug/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/preferences/DebugPreferencesMessages.properties | Adds the UI label string for the new checkbox. |
| debug/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/preferences/DebugPreferencesMessages.java | Adds the corresponding NLS field for the new message key. |
| debug/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/preferences/ConsolePreferencePage.java | Adds a new BooleanFieldEditor for the icon auto-update preference. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ConsoleView.java
Outdated
Show resolved
Hide resolved
debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ConsoleView.java
Show resolved
Hide resolved
debug/org.eclipse.ui.console/src/org/eclipse/ui/console/IConsoleConstants.java
Show resolved
Hide resolved
iloveeclipse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will push updated commit in a moment
debug/org.eclipse.ui.console/src/org/eclipse/ui/console/IConsoleConstants.java
Outdated
Show resolved
Hide resolved
debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ConsoleView.java
Outdated
Show resolved
Hide resolved
debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ConsoleView.java
Outdated
Show resolved
Hide resolved
This commit adds a preference option in console preference for enable/disable dynamic console update based on active console page Fixes: eclipse-platform#2434 Co-authored-by: Andrey Loskutov <loskutov@gmx.de>

This commit adds a preference option in console preference for enable/disable dynamic console update based on active console page
Fixes : #2434