Skip to content

Conversation

@SougandhS
Copy link
Contributor

This commit adds a preference option in console preference for enable/disable dynamic console update based on active console page

image

Fixes : #2434

@merks
Copy link
Contributor

merks commented Jan 22, 2026

It seems kind of "lost at the end" of the preferences. Personally I think it would be better next to the "Pin..." preference.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 22, 2026

Test Results

1 318 files   -   659  1 318 suites   - 659   1h 1m 4s ⏱️ - 31m 10s
4 743 tests ±    0  4 694 ✅  -    25   49 💤 +25  0 ❌ ±0 
9 486 runs   - 4 743  9 359 ✅  - 4 688  127 💤  - 55  0 ❌ ±0 

Results for commit 19c55cd. ± Comparison against base commit 56e8969.

This pull request skips 25 tests.
AutomatedResourceTests AllAliasTests BasicAliasTest ‑ testBug198571
AutomatedResourceTests AllFileSystemTests SymlinkTest ‑ testSymlinkPutHidden
AutomatedResourceTests AllLocalStoreTests MoveTest ‑ testMoveFileAcrossVolumes
AutomatedResourceTests AllLocalStoreTests MoveTest ‑ testMoveFolderAcrossVolumes
AutomatedResourceTests AllRegressionTests Bug_025457 ‑ testFile
AutomatedResourceTests AllRegressionTests Bug_025457 ‑ testFolder
AutomatedResourceTests AllRegressionTests Bug_025457 ‑ testProject
AutomatedResourceTests AllRegressionTests Bug_026294 ‑ testDeleteClosedProjectWindows
AutomatedResourceTests AllRegressionTests Bug_026294 ‑ testDeleteFolderWindows
AutomatedResourceTests AllRegressionTests Bug_026294 ‑ testDeleteOpenProjectWindows
…

♻️ This comment has been updated with latest results.

@SougandhS
Copy link
Contributor Author

It seems kind of "lost at the end" of the preferences. Personally I think it would be better next to the "Pin..." preference.

Agreed, placed next to "Pin.."
image

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a user preference to enable/disable dynamic updating of the Console view icon based on the currently active console page (Fixes #2434).

Changes:

  • Add a new Console preference key and default value for icon auto-update.
  • Add a checkbox to the Console preference page to control icon auto-update.
  • Gate ConsoleView icon updates based on the new preference.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ConsoleView.java Checks the new preference to decide whether to use the dynamic per-console icon or the default icon.
debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ConsoleUIPreferenceInitializer.java Sets the default value for the new preference (enabled).
debug/org.eclipse.ui.console/src/org/eclipse/ui/console/IConsoleConstants.java Introduces the new preference constant in the public constants interface.
debug/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/preferences/DebugPreferencesMessages.properties Adds the UI label string for the new checkbox.
debug/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/preferences/DebugPreferencesMessages.java Adds the corresponding NLS field for the new message key.
debug/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/preferences/ConsolePreferencePage.java Adds a new BooleanFieldEditor for the icon auto-update preference.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@iloveeclipse iloveeclipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will push updated commit in a moment

This commit adds a preference option in console preference for
enable/disable dynamic console update based on active console page

Fixes: eclipse-platform#2434
Co-authored-by: Andrey Loskutov <loskutov@gmx.de>
@iloveeclipse iloveeclipse merged commit bcda9df into eclipse-platform:master Jan 23, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preference to use only old Console view icon

3 participants