Skip to content

Conversation

@eclipse-pde-bot
Copy link
Contributor

The following cleanups were applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Remove unused private constructors
  • Remove unused private fields
  • Remove unused private methods
  • Remove unused private types
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

The following Manifest cleanups where applied:

  • Calculate 'uses' directive for public packages
  • Remove unused dependencies

@github-actions
Copy link

github-actions bot commented Jan 17, 2026

Test Results

   771 files   -  27     771 suites   - 27   56m 33s ⏱️ - 4m 42s
 3 648 tests  -  84   3 593 ✅  -  2   54 💤  -  82  1 ❌ ±0 
10 878 runs   - 249  10 714 ✅  -  3  163 💤  - 246  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit f6ba5b4. ± Comparison against base commit 1e53ff5.

This pull request removes 84 tests.
AllDSAnnotationsTests UnmanagedProjectTest ‑ managedProject
org.eclipse.pde.ds.internal.annotations.tests.DefaultComponentTest ‑ componentImplementationClass
org.eclipse.pde.ds.internal.annotations.tests.DefaultComponentTest ‑ componentName
org.eclipse.pde.ds.internal.annotations.tests.DefaultComponentTest ‑ componentNamespace
org.eclipse.pde.ds.internal.annotations.tests.DefaultComponentTest ‑ componentReference
org.eclipse.pde.ds.internal.annotations.tests.DefaultComponentTest ‑ componentServiceProviderInterface
org.eclipse.pde.ds.internal.annotations.tests.ErrorProjectTest ‑ delayedWithNoServicesError
org.eclipse.pde.ds.internal.annotations.tests.ErrorProjectTest ‑ duplicateConfigurationPidError
org.eclipse.pde.ds.internal.annotations.tests.ErrorProjectTest ‑ factoryImmediateError
org.eclipse.pde.ds.internal.annotations.tests.ErrorProjectTest ‑ factoryOrImmediateServiceFactoryError
…

♻️ This comment has been updated with latest results.

@eclipse-pde-bot eclipse-pde-bot force-pushed the clean-code/ds/org.eclipse.pde.ds.annotations.tests branch 2 times, most recently from 594edfb to e91fe44 Compare January 20, 2026 08:25
Copy link
Contributor

@laeubi laeubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently fails due to

The method assumeTrue(boolean, String) from the type Assumptions refers to the missing type TestAbortedException

seems to be a dependency resolution problem

@eclipse-pde-bot eclipse-pde-bot force-pushed the clean-code/ds/org.eclipse.pde.ds.annotations.tests branch from e91fe44 to f6ba5b4 Compare January 20, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants