Draft: Performance improvements#26

Open

klausschuch wants to merge 295 commits intomainfrom

performance_improvements

This pull request is big! We're only showing the most recent 250 commits

Commits on Jul 11, 2024

fmu2: Filter out connected inputs

Vaan5
authored and
klausschuch
committed
Do not set unconnected variables in every DoStep

Vaan5
authored and
klausschuch
committed
component: Add SyncStart/EndWallClockTime timing results
klausschuch
committed
component: Measure additional times
klausschuch
committed
Do not use uninitialized rtGlobalSimStart
klausschuch
committed
Extract common code into a function

Vaan5
authored and
klausschuch
committed
Enable profiling times with a development flag

Vaan5
authored and
klausschuch
committed
Restructure timings

Vaan5
authored and
klausschuch
committed
Avoid premature simulation end in case of only NeverFinishing components

Vaan5
authored and
klausschuch
committed
Ignore FLUSH_STORE in case of parallel

Vaan5
authored and
klausschuch
committed
Change time format in log file header

Vaan5
authored and
klausschuch
committed
Fix const warnings regarding ChannelValue
klausschuch
committed
Convert path to a normalized absolute path prior to _waccess call

Vaan5
authored and
klausschuch
committed
Implement a memory filter

Vaan5
authored and
klausschuch
committed
Forward correct argument to CompPostDoUpdateState

Vaan5
authored and
klausschuch
committed
Use the MemoryFilter when possible

Vaan5
authored and
klausschuch
committed
Add a switch to disable the MemoryFilter on demand

Vaan5
authored and
klausschuch
committed
Check for cycles when determining the buffer size

Vaan5
authored and
klausschuch
committed
Use >= to check for buffer overflow

Vaan5
authored and
klausschuch
committed
Use SIZE_MAX instead of MEM_FILTER_IDX_FLAG

Vaan5
authored and
klausschuch
committed
Print user's input as a string instead of the converted int value

Vaan5
authored and
klausschuch
committed
Fix compiler warnings

Vaan5
authored and
klausschuch
committed
Define a Vector of pure C objects

Vaan5
authored and
klausschuch
committed
Inline ConnectionInfo into the Connection

Vaan5
authored and
klausschuch
committed
Remove ConnectionData

Vaan5
authored and
klausschuch
committed
Vector: Add SetAt method

Vaan5
authored and
klausschuch
committed
Vector: Hide Resize and expose a Reserve method

Vaan5
authored and
klausschuch
committed
Inline ChannelInfo into the Channel

Vaan5
authored and
klausschuch
committed
Drop ChannelData

Vaan5
authored and
klausschuch
committed
Inline Channel::GetInfo

Vaan5
authored and
klausschuch
committed
Vector optimizations

Vaan5
authored and
klausschuch
committed
Remove unused variables

Vaan5
authored and
klausschuch
committed
Move variables closer to the place where they are used

Vaan5
authored and
klausschuch
committed
Simplify ResultStorage
klausschuch
committed
Check that the Databus channels were set before trying to update their infos
klausschuch
committed
Define a ContainsComponent method

Vaan5
authored and
klausschuch
committed
Submodel utility to properly check container-like components

Vaan5
authored and
klausschuch
committed
Make sure ComponentStorage->Finished is called for comp_solver components

Vaan5
authored and
klausschuch
committed
common_fmu2: Add Fmi2TypeToString() function
klausschuch
committed

Commits on Feb 28, 2025

Use %zu for size_t prints
klausschuch
committed
signals: Add framework for printing function on signal

Dominic Hirtler
authored and
klausschuch
committed
signals: Upgrade current function storage to stack

Dominic Hirtler
authored and
klausschuch
committed
signals: Add possibility to omit redundant argument

Dominic Hirtler
authored and
klausschuch
committed
signals: Add get for function name

Dominic Hirtler
authored and
klausschuch
committed
signals: Add function name to error message on linux

Dominic Hirtler
authored and
klausschuch
committed
signals: Log function on error in component dosteps

Dominic Hirtler
authored and
klausschuch
committed
signals: Improve naming of functions

Dominic Hirtler
authored and
klausschuch
committed
signals: Make callstack handling faster and more straight forward

Dominic Hirtler
authored and
klausschuch
committed
signals: Check stack integrity only on Debug

Dominic Hirtler
authored and
klausschuch
committed
signals: Populate call stack more often

Dominic Hirtler
authored and
klausschuch
committed
signals: Populate call stack on important blocks

Dominic Hirtler
authored and
klausschuch
committed
signals: Populate call stack around cleanup

Dominic Hirtler
authored and
klausschuch
committed
signals: Populate call stack on fmu calls

Dominic Hirtler
authored and
klausschuch
committed
signals: Increase call stack size 3->5

Dominic Hirtler
authored and
klausschuch
committed
signals: Remove individual fmu set/get calls
klausschuch
committed
signals: Add fmi batch functions
klausschuch
committed

Commits on Mar 5, 2025

Set channel reference for outputs as well

Vaan5
authored and
klausschuch
committed
Define info object for storing variable data from the model description

Vaan5
authored and
klausschuch
committed
Construct proxies to array parameters during read

Vaan5
authored and
klausschuch
committed
Only take into account fully tunable maps/curves

Vaan5
authored and
klausschuch
committed
Add ParameterProxies

Vaan5
authored and
klausschuch
committed
Component: Distinguish error/warning in DoStep
klausschuch
committed
results: Make CSV component files resettable

Vaan5
authored and
klausschuch
committed
channel: Add return value to SetFromReference

Herwig Stuetz
authored and
klausschuch
committed
channel: Add return value to SetToReference

Herwig Stuetz
authored and
klausschuch
committed
channel: Add CHANNEL_ARRAY

Herwig Stuetz
authored and
klausschuch
committed
Add ChannelTypeMatch

Herwig Stuetz
authored and
klausschuch
committed
channel: Use ChannelTypeMatch in ChannelInSetReference

Herwig Stuetz
authored and
klausschuch
committed
channel: Use ChannelValueDataSetFromReference in ChannelInUpdate

Herwig Stuetz
authored and
klausschuch
committed
channel: Add error messages

Herwig Stuetz
authored and
klausschuch
committed
channel: Remove unnecessary type checks

Herwig Stuetz
authored and
klausschuch
committed
channel: Add nameInModel to ChannelInfoInit

Herwig Stuetz
authored and
klausschuch
committed
Add ChannelValueDestroy to free ChannelValues on heap

Herwig Stuetz
authored and
klausschuch
committed
channel: Use writeResults as scalar for vectors

Herwig Stuetz
authored and
klausschuch
committed
channel: Make ChannelType a struct

Herwig Stuetz
authored and
klausschuch
committed
channel: Use ChannelType only via references

Herwig Stuetz
authored and
klausschuch
committed
channel: Use ChannelInfo with Dimension instead of VectorChannelInfo

Herwig Stuetz
authored and
klausschuch
committed
storage: Expand arrays to scalars in the csv backend

Herwig Stuetz
authored and
klausschuch
committed
channel: Add ChannelTypeBaseType

Herwig Stuetz
authored and
klausschuch
committed
channel: Add ChannelValueNewScalar

Herwig Stuetz
authored and
klausschuch
committed
constant: Remove use of VectorChannelInfo

Herwig Stuetz
authored and
klausschuch
committed
value: Add array_destroy

Herwig Stuetz
authored and
klausschuch
committed
vector_integrator: Remove use of VectorChannelInfo

Herwig Stuetz
authored and
klausschuch
committed
ChannelValueToString: Support ChannelTypeArray

Herwig Stuetz
authored and
klausschuch
committed
channel: Add ChannelTypeArrayInner

Herwig Stuetz
authored and
klausschuch
committed
fmu: Support ChannelTypeArray

Herwig Stuetz
authored and
klausschuch
committed
channel: Let ChannelValueInit take ownership of type

Herwig Stuetz
authored and
klausschuch
committed
fmu: Move Fmu2ReadFmu2{Scalar,Array}Value to Fmu2Value.c

Herwig Stuetz
authored and
klausschuch
committed
fmu: Check status of Fmu2ReadFmu2{Scalar,Array}Value

Herwig Stuetz
authored and
klausschuch
committed
fmu: Improve error message for "unknown type"

Herwig Stuetz
authored and
klausschuch
committed
fmu: Extend Fmu2ValueSetup to handle arrays

Herwig Stuetz
authored and
klausschuch
committed
icos: Refactor ports and remove VectorChannelInfo

Herwig Stuetz
authored and
klausschuch
committed
channel: Replace double with ChannelValueData for proc functions

Herwig Stuetz
authored and
klausschuch
committed
Move CreateIndexedName to ChannelValue

Herwig Stuetz
authored and
klausschuch
committed
db: Remove DatabusGet{In,Out}VectorChannel{Info,Num}

Herwig Stuetz
authored and
klausschuch
committed
db: Remove DatabusSet{In,Out}RefVector{Channel}

Herwig Stuetz
authored and
klausschuch
committed
channel: Remove VectorChannelInfo

Herwig Stuetz
authored and
klausschuch
committed
fmu: Fix memory cleanup of Fmu2Value

Herwig Stuetz
authored and
klausschuch
committed
channel: Fix memory cleanup of ChannelInfo

Herwig Stuetz
authored and
klausschuch
committed
reader: Fix memory cleanup

Herwig Stuetz
authored and
klausschuch
committed
channel: ChannelOutUpdate: Add error messages to all error returns

Herwig Stuetz
authored and
klausschuch
committed
Rename array -> mcx_array

Herwig Stuetz
authored and
klausschuch
committed
Move mcx_copy to util/stdlib

Herwig Stuetz
authored and
klausschuch
committed
value: Cleanup ChannelValueToString

Herwig Stuetz
authored and
klausschuch
committed
value: Remove obsolete TODOs

Herwig Stuetz
authored and
klausschuch
committed
fmu: Add defaults in actuation switch statement

Herwig Stuetz
authored and
klausschuch
committed
Fix binary channel initialization

Herwig Stuetz
authored and
klausschuch
committed
values: Fix printing of binary values

Herwig Stuetz
authored and
klausschuch
committed
channel: Store type of registered inport reference

Herwig Stuetz
authored and
klausschuch
committed
fmu: Get start value for binary channels

Herwig Stuetz
authored and
klausschuch
committed
monitoring: Add array support to Online Monitor

Herwig Stuetz
authored and
klausschuch
committed
Fix: Correctly set up ChannelInfo

Vaan5
authored and
klausschuch
committed
Fix: Vector does not have PushBackNamed

Vaan5
authored and
klausschuch
committed
Fix: Pass the correct pointer value

Vaan5
authored and
klausschuch
committed
Make FilterFactory arguments explicit

Vaan5
authored and
klausschuch
committed
Create a separate filter for every array element

Vaan5
authored and
klausschuch
committed
Remove unused function

Vaan5
authored and
klausschuch
committed
Add functions for calculating the number of in/out databus elements

Vaan5
authored and
klausschuch
committed
Pre-allocate memory for channel value data used by channel functions

Vaan5
authored and
klausschuch
committed
Do not allocate memory for arrays in UpdateToOutput

Vaan5
authored and
klausschuch
committed
Properly initialize the type in ChannelInData

Vaan5
authored and
klausschuch
committed
Do not forget to call ChannelInfoInit

Vaan5
authored and
klausschuch
committed
Fix indentation

Vaan5
authored and
klausschuch
committed
Fix ChannelDimension definition

Vaan5
authored and
klausschuch
committed
Remove obsolete explicit destruction of channel info

Vaan5
authored and
klausschuch
committed
Do not forget to clone types

Vaan5
authored and
klausschuch
committed
Fix ChannelInfo

Vaan5
authored and
klausschuch
committed
Fix Constant::GetValue

Vaan5
authored and
klausschuch
committed
Fix ConnectionInfo construction

Vaan5
authored and
klausschuch
committed
Extend ConnectionInfo with slice information

Vaan5
authored and
klausschuch
committed
Do not fill internalValue as it is not used anywhere

Vaan5
authored and
klausschuch
committed
Allow registering multiple connections with the same ChannelIn

Vaan5
authored and
klausschuch
committed
Modify type conversions to work with destination/source arguments

Vaan5
authored and
klausschuch
committed
Fix ChannelValueRef definition

Vaan5
authored and
klausschuch
committed
Define 1 type conversion per connection

Vaan5
authored and
klausschuch
committed
Avoid getting connection string (mem allocation) during runtime

Vaan5
authored and
klausschuch
committed
Fix vector integrator

Vaan5
authored and
klausschuch
committed
Make filtered connections operate on sliced data

Vaan5
authored and
klausschuch
committed
Drop indexed vector element indexing in connection definitions

Vaan5
authored and
klausschuch
committed
Add ChannelTypeNumElements

Vaan5
authored and
klausschuch
committed
Add const qualifiers

Vaan5
authored and
klausschuch
committed
Add type conversions scalar -> double array

Vaan5
authored and
klausschuch
committed
Add ChannelDimension utility functions

Vaan5
authored and
klausschuch
committed
Remove const qualifier

Vaan5
authored and
klausschuch
committed
Extend ChannelValueRefSetFromReference to work with slice conversions

Vaan5
authored and
klausschuch
committed
Forward correct types to TypeConversion constructor

Vaan5
authored and
klausschuch
committed
Define writeResults flag as a scalar for SSP as well

Vaan5
authored and
klausschuch
committed
Define mcx_array_set_elem

Vaan5
authored and
klausschuch
committed
Define mcx_array_all and mcx_array_leq

Vaan5
authored and
klausschuch
committed
Implement conditional ChannelValueData element-wise setter

Vaan5
authored and
klausschuch
committed
Support array in RangeConversion

Vaan5
authored and
klausschuch
committed
Do not define ChannelValueArrays if min/max/offset/etc. are not specified

Vaan5
authored and
klausschuch
committed
Fix ChannelDimensionNormalize

Vaan5
authored and
klausschuch
committed
Define scale and offset operation on ChannelValue

Vaan5
authored and
klausschuch
committed
Linear conversion for arrays

Vaan5
authored and
klausschuch
committed
Adapt Dependency matrix generation wrt. array channels

Vaan5
authored and
klausschuch
committed
Adapt UnitConversion to arrays

Vaan5
authored and
klausschuch
committed
Fix log message

Vaan5
authored and
klausschuch
committed
Implement ChannelValueRefSetFromReference

Vaan5
authored and
klausschuch
committed
Add a function to check whether dimensions are conformable (same sizes)

Vaan5
authored and
klausschuch
committed
Add ChannelDimensionsConform

Vaan5
authored and
klausschuch
committed
Add ChannelDimensionGetSliceIndex

Vaan5
authored and
klausschuch
committed
Add Type and Dimension getters for Connection value reference

Vaan5
authored and
klausschuch
committed
Extend arguments of fChannelValueRefElemMapFunc

Vaan5
authored and
klausschuch
committed
Implement ChannelValueRefGetType

Vaan5
authored and
klausschuch
committed
Compare inner types in ChannelTypeEq as well

Vaan5
authored and
klausschuch
committed
Fix return value of mcx_array_get_elem_reference

Vaan5
authored and
klausschuch
committed
Define ChannelTypeConformable

Vaan5
authored and
klausschuch
committed
Adapt TypeConversion to arrays

Vaan5
authored and
klausschuch
committed
Take into account arrays in dependency matrix creation

Vaan5
authored and
klausschuch
committed
Change connection->data->store to the size of the input slice

Vaan5
authored and
klausschuch
committed
Support array channels in FMU 1

Vaan5
authored and
klausschuch
committed
Extend conversions to slices

Vaan5
authored and
klausschuch
committed
Check for duplicate ports and read specific data

Vaan5
authored and
klausschuch
committed
Apply conversions only if necessary

Vaan5
authored and
klausschuch
committed
Use the correct reference

Vaan5
authored and
klausschuch
committed
Use function instead of member function

Vaan5
authored and
klausschuch
committed
Fix target/source channel reading during ConnectionInfo construction

Vaan5
authored and
klausschuch
committed
Expose the whole source value (not just a slice) in direct connections

Vaan5
authored and
klausschuch
committed
Disable support for co-sim init with vector ports

Vaan5
authored and
klausschuch
committed
ChannelDimension cleanup

Vaan5
authored and
klausschuch
committed
Replace IsValid functions with their channel counterparts

Vaan5
authored and
klausschuch
committed
FMU2: Take into account vector elements during dependency matrix generation

Vaan5
authored and
klausschuch
committed
Move dependency matrix generation code to common

Vaan5
authored and
klausschuch
committed
Optimize const connections away only if the whole destination channel is filled

Vaan5
authored and
klausschuch
committed
Rename ChannelValueReference -> ChannelValueDataPointer

Vaan5
authored and
klausschuch
committed
Mark tunable params as discrete for arrays as well

Vaan5
authored and
klausschuch
committed
Free the dimension of the ChannelValueReference slice

Vaan5
authored and
klausschuch
committed
Make ChannelValueRef a normal struct

Vaan5
authored and
klausschuch
committed
Rename ChannelValueRef -> ChannelValueReference

Vaan5
authored and
klausschuch
committed
Make sure DirectConnection has the correct store size

Vaan5
authored and
klausschuch
committed
ConnectionInfo: free dimensions

Vaan5
authored and
klausschuch
committed
GetInConnectionInfos: Use Vector instead of ObjectContainer

Vaan5
authored and
klausschuch
committed
Make sure to provide a type clone to ChannelValueInit

Vaan5
authored and
klausschuch
committed
Use Vector to store ChannelValueReferences

Vaan5
authored and
klausschuch
committed
Get rid of TODOs

Vaan5
authored and
klausschuch
committed
Rename ChannelDimensionSetDimension argument

Vaan5
authored and
klausschuch
committed
Remove obsolete code

Vaan5
authored and
klausschuch
committed
Avoid memory allocations due to C/C++ interface

Vaan5
authored and
klausschuch
committed
storage: Make utility function accessible to all backends

Dominic Hirtler
authored and
klausschuch
committed
storage: Make function ANSI C compliant

Dominic Hirtler
authored and
klausschuch
committed
Move variables closer to the place where they are used

Vaan5
authored and
klausschuch
committed
Update element channels prior to exiting init mode in connections

Vaan5
authored and
klausschuch
committed
Make additional init step configurable via an environment variable

Vaan5
authored and
klausschuch
committed
ChannelValue: Return error when failing to allocate memory

Dominic Hirtler
authored and
klausschuch
committed
Task: Change default of sumTime to TRUE
klausschuch
committed
task/results: Store RTFactor in Task->Initialize

Dominic Hirtler
authored and
klausschuch
committed
util: Convert relative Dll paths to absolute ones

Dominic Hirtler
authored and
klausschuch
committed
util: Use goto cleanup strategy for handling errors

Dominic Hirtler
authored and
klausschuch
committed
util: Log (Debug) absolute path of Dll

Dominic Hirtler
authored and
klausschuch
committed
Calculate first larger sync time multiple differently depending on SUM_TIME

Vaan5
authored and
klausschuch
committed
util: Expose function for absolute epsilon comparison

Vaan5
authored and
klausschuch
committed
Use absolute epsilon comparison to determine synchronization slots

Vaan5
authored and
klausschuch
committed
Use same way of checking for sync slots both in component and step type

Vaan5
authored and
klausschuch
committed
Remove obsolete code

Vaan5
authored and
klausschuch
committed
Define a leq comparison function using absolute epsilon comparison

Vaan5
authored and
klausschuch
committed
Add const qualifiers

Vaan5
authored and
klausschuch
committed
Add const qualifier

Vaan5
authored and
klausschuch
committed
FMU2: Correctly use dimensions of naming convention arrays

Vaan5
authored and
klausschuch
committed
Correctly check if cloning was successful

Vaan5
authored and
klausschuch
committed
fmu: Remove check for valid dimension_1/2

Dominic Hirtler
authored and
klausschuch
committed
Use %zu for size_t
klausschuch
committed
FMI2: Read unit of local values

Vaan5
authored and
klausschuch
committed
Add error log messages

Vaan5
authored and
klausschuch
committed
Check the reference only once at the beginning

Vaan5
authored and
klausschuch
committed
Define a typedef for the dimension type

Vaan5
authored and
klausschuch
committed
Use McxStatus as return type of channel functions

Vaan5
authored and
klausschuch
committed
Remove obsolete return

Vaan5
authored and
klausschuch
committed
Calculate for loop bounds outside

Vaan5
authored and
klausschuch
committed
Indentation

Vaan5
authored and
klausschuch
committed
Add log message

Vaan5
authored and
klausschuch
committed
Remove rebase artifacts

Vaan5
authored and
klausschuch
committed
Fix indexing formula

Vaan5
authored and
klausschuch
committed
channel: Inline ChannelInData (Performance!)

Dominic Hirtler
authored and
klausschuch
committed
channel: Inline ChannelOutData (Performance!)

Dominic Hirtler
authored and
klausschuch
committed
channel: Reduce redirections on in connections (Performance!)

Dominic Hirtler
authored and
klausschuch
committed
channel: Reduce redirections of ValueReferences (Performance!)

Dominic Hirtler
authored and
klausschuch
committed
channel: Reduce redirections of conversions (Performance!)

Dominic Hirtler
authored and
klausschuch
committed
channel: Reduce redirections of out connections (Performance!)

Dominic Hirtler
authored and
klausschuch
committed
channel: Fix datatype of function argument

Dominic Hirtler
authored and
klausschuch
committed
connection: Inline FilteredConnectionData (Performance!)

Dominic Hirtler
authored and
klausschuch
committed
FilteredConnection: Store single filter pointer directly (Performance!)

Dominic Hirtler
authored and
klausschuch
committed
channel: Write message only in debug (Performance!)

Dominic Hirtler
authored and
klausschuch
committed
Fmu2: Create separate SetVariable for Init (Performance!)

Dominic Hirtler
authored and
klausschuch
committed
channel: Skip unnecessary type checks (Performance!)

Dominic Hirtler
authored and
klausschuch
committed
fmu2: Remove variable only needed for warnings/errors (Performance!)

Dominic Hirtler
authored and
klausschuch
committed
channel: Call IsFullyConnected only once (Performance!)

Dominic Hirtler
authored and
klausschuch
committed
channel: Only calculate isFullyConnected on demand (Performance!)

Dominic Hirtler
authored and
klausschuch
committed
channel: Fix Channel dimension index in calculation

Vaan5
authored and
klausschuch
committed
Use %zu for size_t
klausschuch
committed