Add SimpleAddressSpaceComposite for O(1) address space routing #1700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides an alternative to AddressSpaceComposite when routing decisions can be made directly from NodeId, enabling HashMap-based O(1) lookups instead of O(n) filter iteration.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new SimpleAddressSpaceComposite class that provides an alternative to AddressSpaceComposite for scenarios where address space routing decisions can be made directly from a NodeId, enabling HashMap-based O(1) lookups instead of O(n) filter iteration.
Changes:
- Adds
SimpleAddressSpaceCompositeabstract class that delegates routing to subclasses viagetAddressSpace(NodeId) - Implements all AddressSpaceFragment methods with efficient routing
- Includes comprehensive documentation with usage examples
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.../sdk-server/src/main/java/org/eclipse/milo/opcua/sdk/server/SimpleAddressSpaceComposite.java
Show resolved
Hide resolved
.../sdk-server/src/main/java/org/eclipse/milo/opcua/sdk/server/SimpleAddressSpaceComposite.java
Show resolved
Hide resolved
.../sdk-server/src/main/java/org/eclipse/milo/opcua/sdk/server/SimpleAddressSpaceComposite.java
Outdated
Show resolved
Hide resolved
…/server/SimpleAddressSpaceComposite.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
|
@kevinherron I've opened a new pull request, #1701, to work on those changes. Once the pull request is ready, I'll request review from you. |
* Initial plan * Add copyright header to SimpleAddressSpaceComposite Co-authored-by: kevinherron <340273+kevinherron@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kevinherron <340273+kevinherron@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides an alternative to AddressSpaceComposite when routing decisions can be made directly from NodeId, enabling HashMap-based O(1) lookups instead of O(n) filter iteration.