Remove ICU4J (com.ibm.icu) dependency, replace with java.text#163
Merged
Remove ICU4J (com.ibm.icu) dependency, replace with java.text#163
Conversation
All com.ibm.icu.text.* usages replaced with java.text.* equivalents. Mostly a simple swap, with two specifics: - DecimalFormatSymbols.getPlusSign() does not exist in java.text so we have a hardcoded '+' symbol. - NumberFormat.parse() loses precision for values beyond 'long' range, so in cases where we expect we might go over, we use setParseBigDecimal(). Majority of cases it's not required since that would be a 8PB heap, and we are hopefully a few years away from that. This removes com.ibm.icu.text from MANFIEST.MF and the com.ibm.icu plugin feature and some docs/comments.
krumts
approved these changes
Mar 5, 2026
Contributor
krumts
left a comment
krumts
left a comment
There was a problem hiding this comment.
LGTM. I think the differences are acceptable, and we get rid the dependency by this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While investigating #145, I learned that Eclipse has already deprecated usage of icu4j, even though there's no active campaign to migrate. But we can do the work ourselves!
All com.ibm.icu.text.* usages replaced with java.text.* equivalents.
Mostly a simple swap, with two specifics:
This removes com.ibm.icu.text from MANFIEST.MF and the com.ibm.icu plugin feature and some docs/comments.