Skip to content

Fix periodic updates, cell rendering (keyboard navigation, edit entry), add gdbtarget - #185

Merged
jreineckearm merged 4 commits into
eclipse-cdt-cloud:mainfrom
jreineckearm:window-defects
Sep 7, 2026
Merged

jreineckearm merged 4 commits into
eclipse-cdt-cloud:mainfrom
jreineckearm:window-defects

Conversation

@jreineckearm

Copy link
Copy Markdown
Contributor

Fixes #184

What it does

  • Adds incrementing refresh and selection IDs to memoized row data. Forces PrimeReact cells to rerender after memory content changes or cell selection even if the rest of the data remains the same.
  • Adds gdbtarget debug type to defaults.

How to test

Try the features mentioned in #184 .

Review checklist

Reminder for reviewers

Signed-off-by: Jens Reinecke <jens.reinecke@arm.com>
Signed-off-by: Jens Reinecke <jens.reinecke@arm.com>
Signed-off-by: Jens Reinecke <jens.reinecke@arm.com>
@jreineckearm

Copy link
Copy Markdown
Contributor Author

Struggling a bit to find reviewers. @StavrosKolliasArm , @xoriath would you mind having a look?
@planger , maybe you too?

@StavrosKolliasArm StavrosKolliasArm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small chenges

Comment thread src/webview/memory-webview-view.tsx Outdated
Comment thread src/common/memory.ts Outdated
Signed-off-by: Jens Reinecke <jens.reinecke@arm.com>

@StavrosKolliasArm StavrosKolliasArm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me 👍

@jreineckearm
jreineckearm merged commit 531f110 into eclipse-cdt-cloud:main Sep 7, 2026
5 checks passed
@github-project-automation github-project-automation Bot moved this from In Review to To Validate in CDT Cloud Debug (Experimental) Sep 7, 2026
@jreineckearm

Copy link
Copy Markdown
Contributor Author

Thanks, merging based on @StavrosKolliasArm 's feedback. Happy to consider feedback from others after that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

Cell updates + rendering not properly working

2 participants