Fix load hex file - #175
Merged
jreineckearm merged 4 commits intoSep 9, 2026
Merged
Conversation
jreineckearm
left a comment
jreineckearm
left a comment
Contributor
There was a problem hiding this comment.
Apologies for the long delay in the review.
Implementation looks good. See a few questions/suggestions.
How much of the standard does it support? IIRC, other packages we looked at in the past usually missed one or the other part.
Still need to take it for a spin.
StavrosKolliasArm
force-pushed
the
fix-load-hex
branch
from
September 8, 2026 08:56
3893927 to
e4fb7ea
Compare
jreineckearm
reviewed
Sep 8, 2026
jreineckearm
left a comment
jreineckearm
left a comment
Contributor
There was a problem hiding this comment.
Code changes look good. Taking for a spin in the morning before merge.
jreineckearm
approved these changes
Sep 9, 2026
jreineckearm
left a comment
jreineckearm
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the updates, @StavrosKolliasArm .
I took it for another spin and compared behavior with last Memory Inspector release (1.2.0):
- Only difference between files written with old and new writer is that the new writer adds an additional line ending at the end of file. I'd expect this to do no harm and verified it can be loaded with the old reader.
- I was able to read back now a file stored for a memory location > 0x80000000 (Arm v7-M based target, i.e. 32-bit address space). The same file failed with the old reader.
- I tried a couple of odd lengths, which look good.
Happy to merge, thanks a lot for your contribution!
github-project-automation
Bot
moved this from In Review
to To Validate
in CDT Cloud Debug (Experimental)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Fixes the issue
#172
Removes dependancy nrf-intel-hex
How to test
Review checklist
Reminder for reviewers