fix: do not create default index bloom filter during digest#3
Open
utkonos wants to merge 2 commits into
Open
Conversation
The C++ reference only runs the index deduplication check when an explicit index is provided (info != NULL). The Go port unconditionally created a 64 MB bloom filter as a default index, causing features to be silently dropped as duplicates that the C++ reference would keep. This produces fewer bloom filters and fewer features per file, causing hash mismatches across all file sizes. Only create the index when explicitly provided by the caller. Fixes eciavatta#1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The C++ reference only runs the index deduplication check when an explicit index is provided (info != NULL). The Go port unconditionally created a 64 MB bloom filter as a default index, causing features to be silently dropped as duplicates that the C++ reference would keep. This produces fewer bloom filters and fewer features per file, causing hash mismatches across all file sizes.
Only create the index when explicitly provided by the caller.
Fixes #1