Resample with geometry#101
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Hey @leewujung this notebook uses some data from EV. The data is used to compare the resampling function to the way that it is handled in EV. Should I keep it in or add it to a test in EchoPype ? |
|
Closes #82 |
|
Hi @eliascapriles-NOAA, thanks for that! I’ll take a look soon! Also, @leewujung and I discussed this and we think it might be better to have the comparison with EV directly in echopype CI, with some EV-processed data added to the GitHub assets, so that we can test the agreement between both methods directly in echopype (correct me if i'm wrong Wu-Jung!) If we’re happy with the validation there, we could then simply demonstrate its use in this notebook. Let us know what you think, and we can jump on a quick call to discuss this further! Cheers! |
Add notebook using new resample function