Skip to content

Resample with geometry#101

Open
eliascapriles-NOAA wants to merge 1 commit into
echostack-org:mainfrom
eliascapriles-NOAA:main
Open

Resample with geometry#101
eliascapriles-NOAA wants to merge 1 commit into
echostack-org:mainfrom
eliascapriles-NOAA:main

Conversation

@eliascapriles-NOAA
Copy link
Copy Markdown

Add notebook using new resample function

@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@eliascapriles-NOAA
Copy link
Copy Markdown
Author

Hey @leewujung this notebook uses some data from EV. The data is used to compare the resampling function to the way that it is handled in EV. Should I keep it in or add it to a test in EchoPype ?

@LOCEANlloydizard
Copy link
Copy Markdown
Collaborator

LOCEANlloydizard commented May 13, 2026

Closes #82

@LOCEANlloydizard
Copy link
Copy Markdown
Collaborator

Hi @eliascapriles-NOAA, thanks for that! I’ll take a look soon! Also, @leewujung and I discussed this and we think it might be better to have the comparison with EV directly in echopype CI, with some EV-processed data added to the GitHub assets, so that we can test the agreement between both methods directly in echopype (correct me if i'm wrong Wu-Jung!) If we’re happy with the validation there, we could then simply demonstrate its use in this notebook. Let us know what you think, and we can jump on a quick call to discuss this further! Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants