Skip to content

[ECHOJS-227] fixed tests with lint #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alesPoz wants to merge 14 commits into
base: master
Choose a base branch
from
Open

[ECHOJS-227] fixed tests with lint #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
cbc4501
fixed tests with lint
alesPoz Nov 20, 2019
5548776
fixed tests with lint checking
alesPoz Nov 21, 2019
e648c72
fixed tests with lint pathes
alesPoz Nov 21, 2019
ec8f636
fixed tests
alesPoz Nov 21, 2019
63e5074
fixed tests lint
alesPoz Nov 21, 2019
853ca5e
Merge remote-tracking branch 'origin/master' into ECHOJS-227
alesPoz Nov 21, 2019
f7c9ea3
check fixes
alesPoz Nov 21, 2019
f4dbf67
fixed tests complete
alesPoz Nov 21, 2019
72ddae8
Merge remote-tracking branch 'origin/master' into ECHOJS-227
alesPoz Nov 27, 2019
f14e19a
fixing lint
alesPoz Nov 27, 2019
bcbb3ba
fixed lint issues
alesPoz Nov 27, 2019
dc2b308
Merge remote-tracking branch 'origin/master' into ECHOJS-227
alesPoz Nov 27, 2019
2636bd2
fixed lint
alesPoz Nov 27, 2019
36916f6
fixing issues
alesPoz Nov 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
node_modules/*
dist/*
test/*
scripts/*
4 changes: 3 additions & 1 deletion .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,14 @@ module.exports = {
"extends": "airbnb",
"env": {
"browser": false,
"jest": true
"jest": true,
"mocha": true,
},
"plugins": [
"import"
],
"rules": {
"global-require": 0,
Comment on lines +6 to +12
Copy link
Copy Markdown
Member

@nicklatkovich nicklatkovich Nov 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use this eslint rules only for test folder. And disable this rule for tests too.

"overrides": [{
	"files": ["test/**/*.js"],
	"env": { "mocha": true },
	"rules": { "func-names": 0, "global-require": 0 },
}],

"arrow-parens": [
"error",
"always"
Expand Down
4 changes: 2 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ jobs:
if: tag IS blank
name: "Test lint and audit"
script:
- npm install
- npm run build
- npm run lint
- audit-ci --moderate
- stage: test
Expand All @@ -29,6 +31,4 @@ jobs:
name: "Deploy to npm"
script:
- echo "//registry.npmjs.org/:_authToken=\${NPM_TOKEN}" > .npmrc
- npm install
- npm run build
- ./script.sh
2 changes: 1 addition & 1 deletion test/_test-data.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { PrivateKey, constants } from "../";
import { PrivateKey, constants } from '../';

export const privateKey = PrivateKey.fromWif('5KkYp8qdQBaRmLqLz8WVrGjzkt7E13qVcr7cpdLowgJ1mjRyDx2');
export const accountName = 'nathan';
Expand Down
4 changes: 2 additions & 2 deletions test/_test-utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { strictEqual, ok, fail } from "assert";
import { inspect } from "util";
import { strictEqual, ok, fail } from 'assert';
import { inspect } from 'util';

/**
* @param {() => Promise<any> | any} f
Expand Down
Loading