fix: restore context for resumed sessions - #29
Closed
echoVic wants to merge 1 commit into
Closed
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
Owner
Author
|
Closing as superseded by merged PR #27 / v0.3.7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #28
What changed
session.usagerecords when bootstrapping a recorded session.Root cause
Recorded sessions initialized the runtime surface with
0 / 128000, did not reconstruct legacy usage deltas on resume, and the TUI history path emittedHistoryLoadedwithout an initial typed surface projection.Verification
cargo test -p orca-runtime -p orca-tui --lib -- --test-threads=1: runtime 1008/1009 passed with one existing ACP shutdown timing failure; the failed test passed on three exact reruns.cargo test -p orca-tui --lib -- --test-threads=1: 1037 passed, 0 failed.cargo test -p orca-runtime resumed_legacy_usage_restores_latest_provider_context --lib: passed.cargo test -p orca-tui resumed_legacy_usage_projects_context_before_next_turn --lib: passed.cargo test -p orca-tui provider_context_survives_same_revision_surface_sync_in_footer --lib: passed.cargo check -p orca-runtime -p orca-tui --all-targets: passed.git diff --check: passed.The real reproduced session has cumulative input totals
929128and970611, restoring to41483 / 1000000, displayed ascontext 4%.