fix(feed): prevent hydration mismatch from no-reblog filter - #1707
Open
sentry[bot] wants to merge 1 commit into
Open
fix(feed): prevent hydration mismatch from no-reblog filter#1707sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a
TypeError: Cannot read properties of null (reading 'parentNode')that occurs during React hydration in theFeedListcomponent.Root Cause:
The
FeedListcomponent uses theno-reblogquery parameter to filter entries. This filtering logic was applied immediately on the client-side viauseMemo, while the server-side rendered HTML did not apply this filter (asuseSearchParamsreturnsnullduring SSR). This discrepancy led to a structural mismatch between the server-rendered DOM and the client's expected DOM, causing React to fail during hydration.Solution:
The fix defers the application of the
no-reblogfilter until after the component has successfully hydrated on the client. Amountedstate flag is introduced, initialized tofalseand set totruein auseEffecthook that runs only after the initial render. TheuseMemohook that extracts and filters entries now only applies theno-reblogfilter whenmountedistrue. This ensures that both the server and the initial client render produce the same unfiltered list, preventing the hydration mismatch and subsequent error.Fixes ECENCY-NEXT-1FPX
This PR was automatically generated by Sentry. You can adjust this setting at any time.