Conversation
tests/sdt-test.py
Outdated
There was a problem hiding this comment.
please explain those numbers in a comment or declare them as variables
tests/sdt-test.py
Outdated
There was a problem hiding this comment.
Could we use os.getcwd() to get the current working directory?
https://docs.python.org/3/library/os.html#os.getcwd
tests/sdt-test.py
Outdated
There was a problem hiding this comment.
Since we only need namedtuple, let's use this format: from collections import namedtuple.
tests/sdt-test.py
Outdated
There was a problem hiding this comment.
Align with first argument of the fonction
tests/sdt-test.py
Outdated
There was a problem hiding this comment.
lets use single quote everywhere to define strings
tests/sdt-test.py
Outdated
There was a problem hiding this comment.
Using exceptions here, would be more pythonic
tests/sdt-test.py
Outdated
There was a problem hiding this comment.
Could you define this list in variable out of the function call?
tests/sdt-test.py
Outdated
There was a problem hiding this comment.
Align with the function call.
tests/sdt-test.py
Outdated
There was a problem hiding this comment.
Here, explain our definition of offset and address and why we need this function.
Makefile is for building the binaries necessary for testing the library. Signed-off-by: Erica Bugden <erica.bugden@efficios.com>
3 participants
Feedback concerning the completeness and the accuracy of the tests would be much appreciated.
Also maybe suggestions for how to make the error management in the Python more pythonic.