Repository navigation
fix: add missing CI env vars to security workflow - #12
Merged
Merged
Conversation
…ion)
The SBOM and OWASP jobs use ci-settings.xml which references
${env.GITHUBORG}, ${env.GITHUBACTOR}, ${env.GITHUBTOKEN},
${env.MAVEN_PROXY_URL}, ${env.NEXUS_USERNAME}, ${env.NEXUS_PASSWORD}.
These were not set in the security workflow, causing Maven to fail
with 'Illegal character in path' when resolving the parent POM
from GitHub Packages. Mirrors the env block from ci.yml.
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The security workflow now consistently supplies the variables required by ci-settings.xml.
Review effort: Balanced
Findings: None
What changed in this PR
Adds the missing Maven repository credentials and proxy variables to the security workflow.
Changes:
- Mirrors the CI environment configuration.
- Documents why these variables are required.
| File | Description |
|---|---|
.github/workflows/security.yml |
Configures Maven authentication and repository environment variables. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SBOM and OWASP jobs use ci-settings.xml which references env vars (GITHUBORG, GITHUBACTOR, GITHUBTOKEN, MAVEN_PROXY_URL, NEXUS_USERNAME, NEXUS_PASSWORD) that were not set in the security workflow. Maven failed with 'Illegal character in path' when trying to resolve the parent POM from GitHub Packages.
Mirrors the env block from ci.yml.
Root cause of SBOM failure: not the cyclonedx version, but missing env vars for Maven repository resolution.