Repository navigation
Mark end regions by blank gaps - #100
Merged
Merged
Conversation
A long for with no blank line no longer picks up an end marker. The fors that were named only to avoid that marker are expressions again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
insertEndMarkerMinLineswas puttingend foron any comprehension of 10 lines, including ones with no blank line. Scalafmt's blank-gap rule marks a region only when that region contains a blank line, which is the rule Odersky settled on (scalameta/scalafmt#5064).The fors that were bound to a val only so the marker would not appear are expressions again: the two running-tool examples, the signed JWT example,
ProviderApp.run,example.Main.runHttp, and the stdio legacy test. Aforthat is used more than once, or that names a value (parts,connected,cases), stays a val.scalafmtCheckAllis clean. Compiled heddle (JVM, JS, Native), brotli, mcp tests, oauth, example, docs tests, and perfTests.