Repository navigation
Link native test suites as one binary. - #147
Merged
Merged
Conversation
testNative was nine cold closed-world links. A classpath change paid all of them. One unpublished nativeTests binary runs the same 63 suites. The three package-ascent FacadeSpec objects are renamed so that one compilation can see all three.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test-nativepays nine cold Scala Native links whenever a classpath change misses the link checksum. The heddle 0.12 pin run was 10m 32s (sbt 532s, nine links, none skipped). A docs-only pin can skip most of them whentarget/is still in the JVM job's cache. One binary fixes the cold path. No second cache owner.testNativeis nownativeTests/testFull. That unpublished project compiles the native suites from the nine native platforms already inascentMatrices(dom-types, core, dom-core, mount-engine, css, conduit, history, html, datastar).history/src/test/scalajsstays out. Per-module*Native/teststill links that module alone. The alias name is unchanged, soci.ymldoes not change.The three
object FacadeSpecsuites in packageascentare renamed (DomTypesFacadeSpec,CoreFacadeSpec,CssFacadeSpec) so one compilation can hold all three. Suite labels are unchanged. The JSFacadeSpecis untouched.Local
nativeTests/testFull: oneTotal (22918 ms),683 tests passed,0failed, sbtpassed: total 63. That is the same 63 suites the nine jobs reported.Test plan
sbt --server --batch "nativeTests/testFull"locally: one link, 63 suites, 683 leaves, 0 failedtest-nativeon this PR links once