Skip to content

feat: support GPT-6.1 Sol in the model catalog - #237

Merged
eandualem merged 1 commit into
developfrom
feat/gpt-6-1-sol
Sep 30, 2026
Merged

eandualem merged 1 commit into
developfrom
feat/gpt-6-1-sol

Conversation

@eandualem

@eandualem eandualem commented Sep 30, 2026 •

Copy link
Copy Markdown
Owner

Add openai:gpt-6.1-sol to /api/models and recognize its dotted version in the GPT-6 settings branch. Thinking budgets now map to reasoning effort, API Responses chaining settings are applied, and the temperature tunable is omitted. Codex continues to use its existing Responses transport and omit response-ID chaining.

Extend the existing reasoning and host-tool continuation tests to the new identifier, and check that the HTTP catalog exposes it. Model metadata follows the official model documentation.

Validation: make check passed (2,971 tests passed, one database test skipped); provider traffic is mocked. No live model call.

Local review: Codex CLI 0.159.0, gpt-6-astra, high effort, one completed round, zero findings. A separate surveyor source review also found zero issues. The earlier Claude Fable review attempt could not execute because of its account limit; it is not counted as a completed review. Full test results above were obtained outside the reviewer’s read-only sandbox.

Rebased onto merged #236 and reran all checks. The rebase only changed adjacent README context; the model-support patch is unchanged from the Astra-reviewed version. CodeRabbit completed review of head 502035d with zero actionable findings and no inline threads. Its default docstring-coverage suggestion is outside this change and is not a repository-required check; all repository CI checks passed.

Part of #83.

@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 04c19fc3-da4b-41b4-bfd0-3d39502ce053

📥 Commits

Reviewing files that changed from the base of the PR and between 999e60e and 502035d.

📒 Files selected for processing (7)
  • README.md
  • docs/subscription.md
  • src/assistant_runtime/model_catalog.py
  • src/assistant_runtime/services/llm/_settings.py
  • tests/compatibility/test_codex_fast.py
  • tests/unit/app/routes/test_models.py
  • tests/unit/services/llm/test_settings.py

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The change adds openai:gpt-6.1-sol to the model catalog and GPT-6 reasoning-settings matching. Tests and documentation also include the model.

Changes

GPT-6.1 Sol model support

Layer / File(s) Summary
Register model and reasoning settings
src/assistant_runtime/model_catalog.py, src/assistant_runtime/services/llm/_settings.py, tests/unit/app/routes/test_models.py, tests/unit/services/llm/test_settings.py
Adds the model catalog entry and includes the model in GPT-6 reasoning-settings matching. Tests cover the API model listing, reasoning effort, and temperature omission.
Cover host continuation and documentation
tests/compatibility/test_codex_fast.py, README.md, docs/subscription.md
Adds the model to the host-continuation test cases and to the subscription setup and Codex host-tools model references.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 50203

GPT-6.1 Sol support appears covered across the model listing, settings, and host-continuation paths; no actionable merge risk is evident.

Security Architecture Review

Security architecture risk: 🔵 Low · up to 50203

The change reuses existing access and credential controls without establishing a new security concern. External-service behavior has only been checked with simulated responses, leaving limited compatibility and continuation uncertainty.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • inferred — The effective changed exposure is requests selecting the newly supported identifier under existing provider configuration and supplied tool authority. The checked path establishes no additional tenant, data-store, deployment or privilege boundary introduced by the catalog entry.

Trust Boundaries and Controls

  • observed — Existing subscription-only routing rejects API-key aliases, excluded models and missing connected sessions rather than falling back to API credentials. These controls remain downstream of the changed settings classifier.

Resilience and Maintainability Implications

  • observed — Settings construction copies its input mapping and returns new configuration without persisting sessions, response IDs or tool state. Repetition and concurrency introduce no new state transition in this function; downstream lifecycle and recovery behavior remain outside it and were not verified against the live provider.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 14.29% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 5 files. (2 skipped: 2… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the primary change: adding GPT-6.1 Sol support to the model catalog and related handling.
Full details: Docstring Coverage

Explanation

Docstring coverage is 14.29% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 5 files. (2 skipped: 2 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@eandualem
eandualem marked this pull request as ready for review September 30, 2026 12:18
Recognize the dotted GPT-6.1 identifier so configured thinking budgets, Responses settings, and sampling behavior follow the existing GPT-6 path. Exercise the exact model in catalog and Codex host-tool continuation coverage.
@eandualem

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@eandualem
eandualem merged commit 82ecc39 into develop Sep 30, 2026
6 checks passed
@eandualem
eandualem deleted the feat/gpt-6-1-sol branch September 30, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant