Add support for reading monthly GRDC discharge data (.txt)#494
Open
andrevdv wants to merge 5 commits intoeWaterCycle:mainfrom
Open
Add support for reading monthly GRDC discharge data (.txt)#494andrevdv wants to merge 5 commits intoeWaterCycle:mainfrom
andrevdv wants to merge 5 commits intoeWaterCycle:mainfrom
Conversation
Author
|
as for the I kept using the the hardcoded |
Author
|
using actual GRDC 
|
MarkMelotto
approved these changes
Jan 12, 2026
Contributor
|
@andrevdv looking good, good job! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for reading monthly GRDC data from
<station_id>_Q_Month.txt.Unlike daily data, monthly files include three columns:
OriginaldischargeCalculateddischargeFlagindicating the percentage of valid daily values used for the calculationNetCDF support is not implemented. Includes one test.
related to #480