[24122] Fix warning on ubuntu noble

[richiware]

Description

This PR fixes:

../../eprosima/discovery-server/src/DiscoveryServerManager.cpp: In member function ‘void eprosima::discovery_server::DiscoveryServerManager::loadClient(tinyxml2::XMLElement*)’:
../../eprosima/discovery-server/src/DiscoveryServerManager.cpp:1106:28: error: suggest parentheses around assignment used as truth value [-Werror=parentheses]
 1106 |                     if (p4 = std::dynamic_pointer_cast<TCPv4TransportDescriptor>(sp))
      |                         ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@Mergifyio backport 2.1.x 2.0.x 1.2.x

Contributor Checklist

• Commit messages follow the project guidelines.
• The added tests pass locally.
• Changes are backwards compatible.
• New feature has been documented/Current behavior is correctly described in the documentation.
• Applicable backports have been included in the description.

Reviewer Checklist

• The PR has a milestone assigned.
• The title and description correctly express the PR's purpose.
• Check contributor checklist is correct.
• Check CI results: changes do not issue any warning.
• Check CI results: failing tests are unrelated with the changes.

[cferreiragonz]

LGTM with green CI

[richiware]

@Mergifyio backport 2.1.x 2.0.x 1.2.x

[mergify]

backport 2.1.x 2.0.x 1.2.x

✅ Backports have been created

Details

• #134 [24122] Fix warning on ubuntu noble (backport #133) has been created for branch 2.1.x
• #135 [24122] Fix warning on ubuntu noble (backport #133) has been created for branch 2.0.x
• #136 [24122] Fix warning on ubuntu noble (backport #133) has been created for branch 1.2.x but encountered conflicts

Cherry-pick of cb2addc has failed:

On branch mergify/bp/1.2.x/pr-133
Your branch is up to date with 'origin/1.2.x'.

You are currently cherry-picking commit cb2addc.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   src/DiscoveryServerManager.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally