Skip to content

refactor: 불필요한 import 및 ModelAttribute name 속성 제거 #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eGovFrameSupport merged 3 commits into from
Jul 2, 2026
+12 −14
Merged

refactor: 불필요한 import 및 ModelAttribute name 속성 제거 #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
43430cf
refactor: 불필요한 import 및 PathVariable name 속성 제거
LeeBaekHaeng Jun 30, 2026
584fb0c
반영 전 추가 정리
LeeBaekHaeng Jul 1, 2026
60e9468
수정내용 추가
LeeBaekHaeng Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions src/main/java/egovframework/example/sample/web/EgovSampleController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@

import egovframework.example.sample.service.EgovSampleService;
import egovframework.example.sample.service.SampleVO;
import jakarta.annotation.Resource;
import jakarta.validation.Valid;
import lombok.RequiredArgsConstructor;
import lombok.extern.slf4j.Slf4j;

/**
Expand All @@ -43,6 +43,7 @@
* @ 수정일 수정자 수정내용
* @ --------- --------- -------------------------------
* @ 2009.03.16 최초생성
* @ 2026.07.01 [2026년 컨트리뷰션] 불필요한 import 및 ModelAttribute name 속성 제거
*
* @author 개발프레임웍크 실행환경 개발팀
* @since 2009. 03.16
Expand All @@ -53,19 +54,18 @@
*/

@Controller
@RequiredArgsConstructor
@Slf4j
public class EgovSampleController {

/** EgovSampleService */
@Resource(name = "sampleService")
private EgovSampleService sampleService;
private final EgovSampleService sampleService;

/** EgovPropertyService */
@Resource(name = "propertiesService")
private EgovPropertyService propertiesService;
private final EgovPropertyService propertiesService;

@GetMapping("/")
public String index(@ModelAttribute("sampleVO") SampleVO sampleVO, ModelMap model) throws Exception {
public String index(@ModelAttribute SampleVO sampleVO, ModelMap model) throws Exception {
return this.selectSampleList(sampleVO, model);
}

Expand All @@ -77,7 +77,7 @@ public String index(@ModelAttribute("sampleVO") SampleVO sampleVO, ModelMap mode
* @exception Exception
*/
@GetMapping("/egovSampleList.do")
public String selectSampleList(@ModelAttribute("sampleVO") SampleVO sampleVO, ModelMap model) throws Exception {
public String selectSampleList(@ModelAttribute SampleVO sampleVO, ModelMap model) throws Exception {

/** EgovPropertyService.sample */
sampleVO.setPageUnit(propertiesService.getInt("pageUnit"));
Expand Down Expand Up @@ -115,7 +115,7 @@ public String selectSampleList(@ModelAttribute("sampleVO") SampleVO sampleVO, Mo
* @exception Exception
*/
@PostMapping("/addSampleView.do")
public String addSampleView( @ModelAttribute("sampleVO") SampleVO sampleVO, Model model) throws Exception {
public String addSampleView( @ModelAttribute SampleVO sampleVO, Model model) throws Exception {

model.addAttribute("sampleVO", sampleVO);

Expand All @@ -130,7 +130,7 @@ public String addSampleView( @ModelAttribute("sampleVO") SampleVO sampleVO, Mode
* @exception Exception
*/
@PostMapping("/addSample.do")
public String addSample(@Valid @ModelAttribute("sampleVO") SampleVO sampleVO, BindingResult bindingResult, Model model, SessionStatus status) throws Exception {
public String addSample(@Valid @ModelAttribute SampleVO sampleVO, BindingResult bindingResult, Model model, SessionStatus status) throws Exception {

if (bindingResult.hasErrors()) {
model.addAttribute("sampleVO", sampleVO);
Expand All @@ -151,7 +151,7 @@ public String addSample(@Valid @ModelAttribute("sampleVO") SampleVO sampleVO, Bi
* @exception Exception
*/
@PostMapping("/updateSampleView.do")
public String updateSampleView(@ModelAttribute("sampleVO") SampleVO sampleVO, Model model) throws Exception {
public String updateSampleView(@ModelAttribute SampleVO sampleVO, Model model) throws Exception {

SampleVO detail = sampleService.selectSample(sampleVO);
detail.setSearchCondition(sampleVO.getSearchCondition());
Expand All @@ -171,7 +171,7 @@ public String updateSampleView(@ModelAttribute("sampleVO") SampleVO sampleVO, Mo
* @exception Exception
*/
@PostMapping("/updateSample.do")
public String updateSample(@Valid @ModelAttribute("sampleVO") SampleVO sampleVO, BindingResult bindingResult,
public String updateSample(@Valid @ModelAttribute SampleVO sampleVO, BindingResult bindingResult,
Model model, RedirectAttributes redirectAttributes, SessionStatus status) throws Exception {

if (bindingResult.hasErrors()) {
Expand All @@ -197,7 +197,7 @@ public String updateSample(@Valid @ModelAttribute("sampleVO") SampleVO sampleVO,
* @exception Exception
*/
@PostMapping("/deleteSample.do")
public String deleteSample(@ModelAttribute("sampleVO") SampleVO sampleVO, RedirectAttributes redirectAttributes, SessionStatus status) throws Exception {
public String deleteSample(@ModelAttribute SampleVO sampleVO, RedirectAttributes redirectAttributes, SessionStatus status) throws Exception {

sampleService.deleteSample(sampleVO);
status.setComplete();
Expand Down
2 changes: 0 additions & 2 deletions src/test/java/egovframework/example/sample/service/impl/EgovSampleServiceImplTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.doNothing;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
Expand All @@ -34,7 +33,6 @@
import org.mockito.InjectMocks;
import org.mockito.Mock;
import org.mockito.junit.jupiter.MockitoExtension;
import org.springframework.test.util.ReflectionTestUtils;

import egovframework.example.sample.service.SampleVO;

Expand Down