Skip to content

Improve Imitator role balance #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
taelspinner wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Improve Imitator role balance #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a94311e
Imitated ability uses inherit from dead player, persist thru meetings
Oct 15, 2023
33fb80c
Remove debug messages
Oct 15, 2023
3043358
Wrong role referenced
Oct 15, 2023
2a623d0
Merge master
Dec 19, 2023
19057ac
Merge upstream
May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 46 additions & 1 deletion source/Patches/CrewmateRoles/ImitatorMod/MeetingStart.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
using System;
using System.Linq;
using TownOfUs.CrewmateRoles.OracleMod;
using System.Collections.Generic;
using UnityEngine;

namespace TownOfUs.CrewmateRoles.ImitatorMod
{
Expand All @@ -11,8 +13,51 @@ public class MeetingStart
{
public static void Postfix(MeetingHud __instance)
{
if (!PlayerControl.LocalPlayer.Is(RoleEnum.Imitator))
{
// RPC how many uses your ability had left so the Imitator's role knows the accurate count
List<RoleEnum> LimitedUsesRoles = new List<RoleEnum>()
{
RoleEnum.Engineer,
RoleEnum.Veteran,
RoleEnum.VampireHunter,
RoleEnum.Transporter,
RoleEnum.Trapper
};
RoleEnum playerRole = Role.GetRole(PlayerControl.LocalPlayer).RoleType;
if (PlayerControl.LocalPlayer.Data.IsDead && LimitedUsesRoles.Contains(playerRole) && !StartImitate.UpdatedUses)
{
int newUses = 0;
if (playerRole == RoleEnum.Engineer)
{
newUses = ((Engineer)Role.GetRole(PlayerControl.LocalPlayer)).UsesLeft;
}
else if (playerRole == RoleEnum.Veteran)
{
newUses = ((Veteran)Role.GetRole(PlayerControl.LocalPlayer)).UsesLeft;
}
else if (playerRole == RoleEnum.VampireHunter)
{
newUses = ((VampireHunter)Role.GetRole(PlayerControl.LocalPlayer)).UsesLeft;
}
else if (playerRole == RoleEnum.Transporter)
{
newUses = ((Transporter)Role.GetRole(PlayerControl.LocalPlayer)).UsesLeft;
}
else if (playerRole == RoleEnum.Trapper)
{
newUses = ((Trapper)Role.GetRole(PlayerControl.LocalPlayer)).UsesLeft;
}
foreach(var role in Role.GetRoles(RoleEnum.Imitator))
{
// Only needed once per game
StartImitate.UpdatedUses = true;
}
Utils.Rpc(CustomRPC.UpdateImitator, PlayerControl.LocalPlayer.PlayerId, newUses);
}
return;
}
if (PlayerControl.LocalPlayer.Data.IsDead) return;
if (!PlayerControl.LocalPlayer.Is(RoleEnum.Imitator)) return;
var imitatorRole = Role.GetRole<Imitator>(PlayerControl.LocalPlayer);
if (imitatorRole.trappedPlayers != null)
{
Expand Down
65 changes: 60 additions & 5 deletions source/Patches/CrewmateRoles/ImitatorMod/StartImitate.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using UnityEngine;
using Object = UnityEngine.Object;
using TownOfUs.Patches;
using System.Collections.Generic;

namespace TownOfUs.CrewmateRoles.ImitatorMod
{
Expand All @@ -17,6 +18,8 @@ public static class AirshipExileController_WrapUpAndSpawn
public class StartImitate
{
public static PlayerControl ImitatingPlayer;
public static Dictionary<string, int> LimitedRoleUses;
public static bool UpdatedUses = false;
public static void ExileControllerPostfix(ExileController __instance)
{
var exiled = __instance.exiled?.Object;
Expand Down Expand Up @@ -45,6 +48,7 @@ public static void Imitate(Imitator imitator)
{
if (imitator.ImitatePlayer == null) return;
ImitatingPlayer = imitator.Player;
LimitedRoleUses = imitator.LimitedRoleUses;
var imitatorRole = Role.GetRole(imitator.ImitatePlayer).RoleType;
if (imitatorRole == RoleEnum.Haunter)
{
Expand All @@ -62,12 +66,56 @@ public static void Imitate(Imitator imitator)
if (imitatorRole == RoleEnum.Spy) new Spy(ImitatingPlayer);
if (imitatorRole == RoleEnum.Tracker) new Tracker(ImitatingPlayer);
if (imitatorRole == RoleEnum.Sheriff) new Sheriff(ImitatingPlayer);
if (imitatorRole == RoleEnum.Veteran) new Veteran(ImitatingPlayer);
if (imitatorRole == RoleEnum.Veteran)
{
var veteran = new Veteran(ImitatingPlayer);
if (LimitedRoleUses.ContainsKey("Veteran"))
{
veteran.UsesLeft = LimitedRoleUses["Veteran"];
}
else
{
veteran.UsesLeft = ((Veteran)Role.GetRole(imitator.ImitatePlayer)).UsesLeft;
}
}
if (imitatorRole == RoleEnum.Altruist) new Altruist(ImitatingPlayer);
if (imitatorRole == RoleEnum.Engineer) new Engineer(ImitatingPlayer);
if (imitatorRole == RoleEnum.Engineer)
{
var engi = new Engineer(ImitatingPlayer);
if (LimitedRoleUses.ContainsKey("Engineer"))
{
engi.UsesLeft = LimitedRoleUses["Engineer"];
}
else
{
engi.UsesLeft = ((Engineer)Role.GetRole(imitator.ImitatePlayer)).UsesLeft;
}
}
if (imitatorRole == RoleEnum.Medium) new Medium(ImitatingPlayer);
if (imitatorRole == RoleEnum.Transporter) new Transporter(ImitatingPlayer);
if (imitatorRole == RoleEnum.Trapper) new Trapper(ImitatingPlayer);
if (imitatorRole == RoleEnum.Transporter)
{
var trans = new Transporter(ImitatingPlayer);
if (LimitedRoleUses.ContainsKey("Transporter"))
{
trans.UsesLeft = LimitedRoleUses["Transporter"];
}
else
{
trans.UsesLeft = ((Transporter)Role.GetRole(imitator.ImitatePlayer)).UsesLeft;
}
}
if (imitatorRole == RoleEnum.Trapper)
{
var trapper = new Trapper(ImitatingPlayer);
if (LimitedRoleUses.ContainsKey("Trapper"))
{
trapper.UsesLeft = LimitedRoleUses["Trapper"];
}
else
{
trapper.UsesLeft = ((Trapper)Role.GetRole(imitator.ImitatePlayer)).UsesLeft;
}
}
if (imitatorRole == RoleEnum.Oracle) new Oracle(ImitatingPlayer);
if (imitatorRole == RoleEnum.Medic)
{
Expand All @@ -78,7 +126,14 @@ public static void Imitate(Imitator imitator)
if (imitatorRole == RoleEnum.VampireHunter)
{
var vh = new VampireHunter(ImitatingPlayer);
vh.UsesLeft = CustomGameOptions.MaxFailedStakesPerGame;
if (LimitedRoleUses.ContainsKey("VampireHunter"))
{
vh.UsesLeft = LimitedRoleUses["VampireHunter"];
}
else
{
vh.UsesLeft = ((VampireHunter)Role.GetRole(imitator.ImitatePlayer)).UsesLeft;
}
vh.AddedStakes = true;
}
if (imitatorRole == RoleEnum.Aurial)
Expand Down
7 changes: 7 additions & 0 deletions source/Patches/CrewmateRoles/ImitatorMod/StopImitate.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ public static void Prefix(PlayerControl __instance, [HarmonyArgument(0)] GameDat
{
List<RoleEnum> trappedPlayers = null;
PlayerControl confessingPlayer = null;
Dictionary<string, int> LimitedRoleUses = StartImitate.LimitedRoleUses;

if (PlayerControl.LocalPlayer == StartImitate.ImitatingPlayer)
{
Expand All @@ -31,6 +32,7 @@ public static void Prefix(PlayerControl __instance, [HarmonyArgument(0)] GameDat
if (PlayerControl.LocalPlayer.Is(RoleEnum.Engineer))
{
var engineerRole = Role.GetRole<Engineer>(PlayerControl.LocalPlayer);
LimitedRoleUses["Engineer"] = engineerRole.UsesLeft;
Object.Destroy(engineerRole.UsesText);
}

Expand All @@ -45,6 +47,7 @@ public static void Prefix(PlayerControl __instance, [HarmonyArgument(0)] GameDat
if (PlayerControl.LocalPlayer.Is(RoleEnum.VampireHunter))
{
var vhRole = Role.GetRole<VampireHunter>(PlayerControl.LocalPlayer);
LimitedRoleUses["VampireHunter"] = vhRole.UsesLeft;
Object.Destroy(vhRole.UsesText);
}

Expand All @@ -58,6 +61,7 @@ public static void Prefix(PlayerControl __instance, [HarmonyArgument(0)] GameDat
if (PlayerControl.LocalPlayer.Is(RoleEnum.Transporter))
{
var transporterRole = Role.GetRole<Transporter>(PlayerControl.LocalPlayer);
LimitedRoleUses["Transporter"] = transporterRole.UsesLeft;
Object.Destroy(transporterRole.UsesText);
if (transporterRole.TransportList != null)
{
Expand All @@ -72,12 +76,14 @@ public static void Prefix(PlayerControl __instance, [HarmonyArgument(0)] GameDat
if (PlayerControl.LocalPlayer.Is(RoleEnum.Veteran))
{
var veteranRole = Role.GetRole<Veteran>(PlayerControl.LocalPlayer);
LimitedRoleUses["Veteran"] = veteranRole.UsesLeft;
Object.Destroy(veteranRole.UsesText);
}

if (PlayerControl.LocalPlayer.Is(RoleEnum.Trapper))
{
var trapperRole = Role.GetRole<Trapper>(PlayerControl.LocalPlayer);
LimitedRoleUses["Trapper"] = trapperRole.UsesLeft;
Object.Destroy(trapperRole.UsesText);
trapperRole.traps.ClearTraps();
trappedPlayers = trapperRole.trappedPlayers;
Expand Down Expand Up @@ -121,6 +127,7 @@ public static void Prefix(PlayerControl __instance, [HarmonyArgument(0)] GameDat
var imitator = new Imitator(StartImitate.ImitatingPlayer);
imitator.trappedPlayers = trappedPlayers;
imitator.confessingPlayer = confessingPlayer;
imitator.LimitedRoleUses = LimitedRoleUses;
var newRole = Role.GetRole(StartImitate.ImitatingPlayer);
newRole.RemoveFromRoleHistory(newRole.RoleType);
newRole.Kills = killsList.Kills;
Expand Down
1 change: 1 addition & 0 deletions source/Patches/CustomRPC.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ public enum CustomRPC
HunterStalk,
HunterCatchPlayer,
Retribution,
UpdateImitator,

BypassKill,
BypassMultiKill,
Expand Down
1 change: 1 addition & 0 deletions source/Patches/Roles/Imitator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ public class Imitator : Role

public List<RoleEnum> trappedPlayers = null;
public PlayerControl confessingPlayer = null;
public Dictionary<string, int> LimitedRoleUses = new Dictionary<string, int>();


public Imitator(PlayerControl player) : base(player)
Expand Down
25 changes: 25 additions & 0 deletions source/Patches/RpcHandling.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1215,6 +1215,31 @@ public static void Postfix([HarmonyArgument(0)] byte callId, [HarmonyArgument(1)
var lastVoted = Utils.PlayerById(reader.ReadByte());
AssassinKill.MurderPlayer(lastVoted);
break;
case CustomRPC.UpdateImitator:
var updatedPlayer = Utils.PlayerById(reader.ReadByte());
int newUses = reader.ReadInt32();
var playerRole = Role.GetRole(updatedPlayer);
if (playerRole.RoleType == RoleEnum.Engineer)
{
((Engineer)playerRole).UsesLeft = newUses;
}
else if (playerRole.RoleType == RoleEnum.Veteran)
{
((Veteran)playerRole).UsesLeft = newUses;
}
else if (playerRole.RoleType == RoleEnum.VampireHunter)
{
((VampireHunter)playerRole).UsesLeft = newUses;
}
else if (playerRole.RoleType == RoleEnum.Transporter)
{
((Transporter)playerRole).UsesLeft = newUses;
}
else if (playerRole.RoleType == RoleEnum.Trapper)
{
((Trapper)playerRole).UsesLeft = newUses;
}
break;
}
}
}
Expand Down