chore(featureflags): remove dead EdgeProvidedSandboxMetricsFlag

[arkamar]

This flag was a temporary migration toggle from #1588 for the sandbox-metrics read path. The consuming code was removed in 9cc1504 ("Make edge api optional for OSS deployment", #1638), which collapsed onto a single cluster resource provider but left this declaration behind as dead code. No references remain.

Link: #1638

[cursor]

PR Summary

Low Risk
Dead-code removal only; no runtime behavior or flag consumers change.

Overview
Removes the unused EdgeProvidedSandboxMetricsFlag (edge-provided-sandbox-metrics) from packages/shared/pkg/featureflags/flags.go.

That toggle was left over after the sandbox-metrics read path and edge-API migration code were removed; nothing in the repo references it anymore.

^{Reviewed by Cursor Bugbot for commit a3955c8. Bugbot is set up for automated code reviews on this repo. Configure here.}

[gemini-code-assist]

Code Review

This pull request removes the unused EdgeProvidedSandboxMetricsFlag feature flag from the shared feature flags package. There are no review comments, and we have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[codecov]

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
3123	1	3122	8

View the top 1 failed test(s) by shortest run time

github.com/e2b-dev/infra/tests/integration/internal/tests/api/templates::TestDeleteTemplate

Stack Traces | 163s run time

=== RUN   TestDeleteTemplate
=== PAUSE TestDeleteTemplate
=== CONT  TestDeleteTemplate
    build_template_test.go:133: test-to-delete: [info] Building template kh5llfrms6psijfs5qfy/defeb177-c9ba-4361-b6b0-3909530672d2
    build_template_test.go:133: test-to-delete: [info] [base] FROM ubuntu:22.04 [f9f564014e009a9561a82bf8c84f9314242971e833fb019936654ecba452f184]
    build_template_test.go:133: test-to-delete: [info] Base Docker image size: 30 MB
    build_template_test.go:133: test-to-delete: [info] Creating file system and pulling Docker image
    build_template_test.go:133: test-to-delete: [info] Uncompressing layer sha256:40d16f30db405106ef8074779bdf41f012465c2a785bbeaa2eab9f2081099b47 30 MB
    build_template_test.go:133: test-to-delete: [info] Uncompressing layer sha256:b0b1ae3963e1a8e44d08eb4b731f72fc75a110cadb9ef6edb03c6fcee306b479 13 MB
    build_template_test.go:133: test-to-delete: [info] Uncompressing layer sha256:8c4b1b28875140ed3abacaf16ad0d696f6bef912f52d2148f261a23e3349465b 168 B
    build_template_test.go:133: test-to-delete: [info] Layers extracted
    build_template_test.go:133: test-to-delete: [info] Root filesystem structure: bin, boot, dev, etc, home, lib, lib32, lib64, libx32, media, mnt, opt, proc, root, run, sbin, srv, sys, tmp, usr, var
    build_template_test.go:133: test-to-delete: [info] Provisioning sandbox template
    build_template_test.go:133: test-to-delete: [info] Provisioning was successful, cleaning up
    build_template_test.go:133: test-to-delete: [info] Sandbox template provisioned
    build_template_test.go:133: test-to-delete: [info] [base] DEFAULT USER user [49e586c2171254c6bc4a09e84eedac32dbcf113a158c24248129af2f49cbed74]
    build_template_test.go:133: test-to-delete: [info] [builder 1/1] RUN echo 'Hello, World!' [c72b4f813c2a16b0fc1a1c5da7b1365a304cbac516b22dc304a71f70aae48ac0]
    build_template_test.go:133: test-to-delete: [info] [builder 1/1] [stdout]: Hello, World!
    build_template_test.go:133: test-to-delete: [info] [finalize] Finalizing template build [92c524e30533398ebb41ce04c2596130f0cdecc9aa328e28fdb16a1b11f61d62]
    build_template_test.go:133: test-to-delete: [error] Build failed: build was cancelled
    delete_template_test.go:18: Build failed: {<nil> build was cancelled <nil>}
--- FAIL: TestDeleteTemplate (162.62s)

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

[claude]

LGTM — dead flag removal, verified no references remain.

Extended reasoning...

Overview

Single-line deletion in packages/shared/pkg/featureflags/flags.go removing the EdgeProvidedSandboxMetricsFlag declaration. PR description explains it was a temporary migration toggle from #1588 whose consuming code was removed in #1638.

Security risks

None. Removing an unused feature flag declaration has no runtime security implications.

Level of scrutiny

Low. This is pure dead-code removal in the feature flag registry. Verified via grep that no references to either EdgeProvidedSandboxMetricsFlag (symbol) or edge-provided-sandbox-metrics (LD key string) exist anywhere in the repo.

Other factors

The change is one line, mechanical, and self-contained. No behavior change. Safe to approve without human review.