fix: run full n8n-node lint in CI#5
Merged
Conversation
pnpm-workspace.yaml declared no packages field, so pnpm 11 errored "packages field missing or empty" whenever n8n-node lint shelled out to pnpm — making `pnpm lint` unrunnable. CI masked this by running `pnpm lint:basic` (plain eslint) instead of the full `pnpm lint`. - Add `packages: [.]` to pnpm-workspace.yaml so n8n-node lint runs. - Switch CI lint step from `pnpm lint:basic` to `pnpm lint`. Verified: pnpm install --frozen-lockfile, pnpm lint, pnpm typecheck all pass (lint was previously erroring). Unblocks n8n community-node verification, which expects the full lint to pass.
tomasvarga
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm-workspace.yamlhad nopackages:field, so pnpm 11 (pinned viapackageManager) erroredpackages field missing or emptywhenevern8n-node lintshelled out to pnpm —pnpm lintwas unrunnable.pnpm lint:basic(plain eslint) instead of the fullpnpm lint(n8n-node lint).packages: [.]) and switch the CI lint step topnpm lint.Unblocks n8n community-node verification, which expects the full
n8n-node lintto pass.Test plan
pnpm install --frozen-lockfile— clean, no lockfile driftpnpm lint— exits 0 (previouslyERROR packages field missing or empty)pnpm typecheck— exits 0