-
Notifications
You must be signed in to change notification settings - Fork 215
Update dependency numpy to v2.4.6 #285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,8 +20,8 @@ | |
| joblib==1.5.3 | ||
| librosa==0.11.0 | ||
| nltk==3.9.4 | ||
| numpy==2.3.5 | ||
| numpy==2.4.6 | ||
| numba==0.63.1 | ||
|
Check failure on line 24 in template/requirements.txt
|
||
|
Comment on lines
+23
to
24
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔴 numpy is bumped to 2.4.6 while numba remains pinned at 0.63.1, whose published metadata declares Extended reasoning...What's wrong
The upper bound How it manifests
Step-by-step proof
Why existing code doesn't catch this Renovate updated numpy in isolation; nothing in the repo cross-checks compatible numpy/numba pairings before opening the PR. The conflict only surfaces at install time, which is precisely when the template build runs. Fix Bump numba in the same PR to a release that allows numpy 2.4 — for reference, numba 0.65.1 declares |
||
| opencv-python==4.11.0.86 | ||
| openpyxl==3.1.5 | ||
| plotly==6.0.1 | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This template still installs
numba==0.63.1on the next line, and Numba's official install matrix for 0.63.1 supports NumPy2.0 <= version < 2.4; pinningnumpy==2.4.6makes thepip install --no-cache-dir -r requirements.txtstep intemplate/template.pyunsatisfiable, so template builds that install this requirements file will fail unless Numba is upgraded to a release with NumPy 2.4 support.Useful? React with 👍 / 👎.