Bug matlab2026removed check gradients#907
Closed
JenHardt wants to merge 8 commits into
Closed
Conversation
…on in kernel interpolation
… considered correctly.
… in base data and photon dose caluclation (SVDPB). * New machine file version introduced with version field. * Downwards compatibility checked (old files are assumed as version 1) and modifies docs and changelog as well.
…ult is false anyway
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #907 +/- ##
==========================================
- Coverage 54.86% 54.80% -0.06%
==========================================
Files 320 320
Lines 20527 20555 +28
==========================================
+ Hits 11262 11266 +4
- Misses 9265 9289 +24 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MATLAB 2026 removed the CheckGradients option (see https://de.mathworks.com/help/optim/release-notes.html), which caused this to fail in that version. The variable was removed. This change should remain backward compatible, since the default value for this option was already false anyway.