Fix sparse CT scenario indexing#905
Conversation
|
Can you check if this ist sill relevant on the dev branch? As said in #904 , the dev_varRBErobOpt has been merged into dev a while ago (and was also part of the last releases), and I remember fixing something similar on dev. |
|
I would like to add some context on the direction that has been explored in my personal The current This generalization naturally increases the number of scenarios used, and therefore the RAM requirements and computation time needed to calculate and store the corresponding dose influence data. However, this type of architecture can still be practical when combined with scenario-free robust optimization models, such as probabilistic robust optimization (https://doi.org/10.1002/mp.17905) or interval analysis-based robust optimization (https://doi.org/10.3390/cancers17030504). These approaches can aggregate scenario information into probabilistic or interval quantities, so the final optimization problem does not scale directly with the number of scenarios as it would in a conventional per-scenario robust optimization formulation. A base implementation of this scenario architecture is available in the https://github.com/acsevillam/matRad/tree/dev_robOpt In the coming weeks, I plan to open a related PR with a smaller and reviewable first step in this direction. For now, I would appreciate your thoughts on the general approach. |
Bug description
Sparse CT scenario models can fail when the active CT scenario id is not equal to its row position in ctScenProb.
Approach
This PR disambiguates CT scenario position from real CT scenario id in sub2scenIx and fixes extractSingleScenario to select ctScenProb rows by CT scenario id.
Open Questions and/or Concerns
References
None.