Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
The default behavior of automatically powering on the adapter device may not be preferred by the user. In my use case I sometimes want the adapter device to powered off and I'd prefer iwmenu to not automatically power it on when I'm not intended it to. This causes the user to have to power off the adapter device when iwmenu is launched even though they may have not intended for it to be powered it on.
Solution:
Add an argument:
--no-auto-power-on. This keeps the existing behavior as the default behavior, but gives the user the option to disable it.Note that this assumes PR 29 becomes merged. Clean diff.
PRs 28-30 are my first attempts at creating PRs. I'm not a developer and I don't have experience with Rust, but this project is perfect for my use case. I noticed a few odd behaviors and I felt I could debug and fix them. I'd appreciate any feedback and a review to see if I've identified the problems and solutions appropriately. Thank you.